From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 417 invoked by alias); 5 Sep 2003 02:59:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 407 invoked from network); 5 Sep 2003 02:59:19 -0000 Received: from unknown (HELO mail04.idc.renesas.com) (202.234.163.13) by sources.redhat.com with SMTP; 5 Sep 2003 02:59:19 -0000 Received: from mail04.idc.renesas.com ([127.0.0.1]) by mail04.idc.renesas.com with ESMTP id h852xHEl007823 for ; Fri, 5 Sep 2003 11:59:17 +0900 (JST) Received: from guardian02.idc.renesas.com ([172.20.8.133]) by mail04.idc.renesas.com with ESMTP id h852xGYB007820 for ; Fri, 5 Sep 2003 11:59:16 +0900 (JST) Received: (from root@localhost) by guardian02.idc.renesas.com with id h852xE1e011707 for gdb-patches@sources.redhat.com; Fri, 5 Sep 2003 11:59:14 +0900 (JST) Received: from unknown [172.20.8.70] by guardian02.idc.renesas.com with SMTP id MAA11706 ; Fri, 5 Sep 2003 11:59:14 +0900 Received: from mta03.idc.renesas.com (localhost [127.0.0.1]) by mta03.idc.renesas.com with ESMTP id h852xEVJ029401 for ; Fri, 5 Sep 2003 11:59:15 +0900 (JST) Received: from rnsmtp01.hoku_r.renesas.com ([10.145.246.51]) by mta03.idc.renesas.com with ESMTP id h852xERJ029398 for ; Fri, 5 Sep 2003 11:59:14 +0900 (JST) Received: from mrkaisv.hoku.renesas.com ([10.145.105.245]) by rnsmtp01.hoku_r.renesas.com (8.9.3/3.7W) with ESMTP id LAA07109 for ; Fri, 5 Sep 2003 11:59:14 +0900 (JST) Received: from KEI (unknown [10.145.105.81]) by mrkaisv.hoku.renesas.com (Postfix) with SMTP id 5B6C6798501 for ; Fri, 5 Sep 2003 11:59:14 +0900 (JST) Message-ID: <012d01c37359$e3f98510$5169910a@KEI> From: "Kei Sakamoto" To: References: <02e201c35a5e$883a8cb0$5169910a@KEI> <20030817210347.GF11300@nevyn.them.org> <01af01c3679d$25650650$5169910a@KEI> Subject: Re: [patch] New m32r remote target, m32rsdi Date: Fri, 05 Sep 2003 02:59:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-09/txt/msg00055.txt.bz2 Hello, I posted the following two weeks ago, but there is no reaction so far. Its patch adds a new remote protocol to m32r architecture and does not influence any other functions. So I think it's safe to add. I'm going to commit it next weak. Please let me know if there is any problem. Kei Sakamoto From: "Kei Sakamoto" To: "Daniel Jacobowitz" Cc: Sent: Thursday, August 21, 2003 1:31 PM Subject: Re: [patch] New m32r remote target, m32rsdi > > On Mon, Aug 04, 2003 at 05:00:55PM +0900, Kei Sakamoto wrote: > > > Hello, > > > > > > The attached adds a new remote target, m32rsdi, which uses > > > m32r's on-chip debug interface, SDI (Scalable Debug Interface). > > > > > > In m32rsdi target mode, gdb does not control a target board > > > directly. Instead, gdb sends commands to "sdiserver" by sockets > > > interface. Sdiserver is a program which controls the target > > > board using printer ports. > > > > > > Is this OK to commit? > > > > > > Kei Sakamoto > > > > > > ==== > > > > > > 2003-08-04 Kei Sakamoto > > > > > > > > > * remote-m32r-sdi.c : New file, interface to m32r on-chip > > > debug interface, SDI (Scalable Debug Interface). > > > * Makefile.in (remote-m32r-sdi.o): Add build rule. > > > * config/m32r/m32r.mt (TDEPFILES) : Add remote-m32r-sdi.o. > > > > I don't feel qualified to review a new remote target, so you'll have to > > ask the remote maintainer. However, there's definitely a problem with > > the new code. It's full of pieces like: > > > > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > *((unsigned long *) (buf + 1)) = pc_addr; > > else > > *((unsigned long *) (buf + 1)) = pc_addr - 1; > > > > This sends host-endian data over the wire to the target. Run it on a > > big-endian host and bad things will happen. > > Thank you for reviewing my patch. I revised it and removed > the endian problem. > > I've tested the attached patch on both Linux/Pentium-III and > Soralis/Sparc4. So it works fine on both little-endian host > and big-endian host. > > Kei Sakamoto > > ==== > > 2003-08-21 Kei Sakamoto > > * remote-m32r-sdi.c : New file, interface to m32r on-chip > debug interface, SDI (Scalable Debug Interface). > * Makefile.in (remote-m32r-sdi.o): Add build rule. > * config/m32r/m32r.mt (TDEPFILES) : Add remote-m32r-sdi.o. >