Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch/testcase] gdb.base/bang.exp: accespt sim's output
@ 2003-07-04  2:43 Kei Sakamoto
  2003-07-04  3:02 ` Kei Sakamoto
  2003-07-07 14:19 ` Andrew Cagney
  0 siblings, 2 replies; 6+ messages in thread
From: Kei Sakamoto @ 2003-07-04  2:43 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

The attached patch fixes gdb.base/bang.exp so that it accepts
sim's output.

The current test always fails with sim.

(gdb) run
Starting program:
/project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.base/bang!
0

*** EXIT code 0

Program exited normally.
[Switching to process 0]
(gdb) FAIL: gdb.base/bang.exp: run program (the program exited)

[-- Attachment #2: bang.exp.patch --]
[-- Type: application/octet-stream, Size: 400 bytes --]

--- insight-20030703.orig/src/gdb/testsuite/gdb.base/bang.exp	Wed Jun 25 07:04:06 2003
+++ insight-20030703/src/gdb/testsuite/gdb.base/bang.exp	Fri Jul  4 09:17:15 2003
@@ -36,6 +36,6 @@
 
 # Verify that we can run the program and that it terminates normally.
 gdb_test "run" \
-         ".*Program exited normally\." \
+         ".*Program exited normally\..*" \
          "run program"
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch/testcase] gdb.base/bang.exp: accespt sim's output
  2003-07-04  2:43 [patch/testcase] gdb.base/bang.exp: accespt sim's output Kei Sakamoto
@ 2003-07-04  3:02 ` Kei Sakamoto
  2003-07-07 14:19 ` Andrew Cagney
  1 sibling, 0 replies; 6+ messages in thread
From: Kei Sakamoto @ 2003-07-04  3:02 UTC (permalink / raw)
  To: gdb-patches

> The attached patch fixes gdb.base/bang.exp so that it accepts
> sim's output.
> 
> The current test always fails with sim.
> 
> (gdb) run
> Starting program:
> /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.base/bang!
> 0
> 
> *** EXIT code 0
> 
> Program exited normally.
> [Switching to process 0]
> (gdb) FAIL: gdb.base/bang.exp: run program (the program exited)

I'm sorry. I forgot to attach Changelog.

Kei

===

2003-07-04  Kei Sakamoto  <sakamoto.kei@renesas.com>

        * gdb.base/bang.exp: Accept sim output.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch/testcase] gdb.base/bang.exp: accespt sim's output
  2003-07-04  2:43 [patch/testcase] gdb.base/bang.exp: accespt sim's output Kei Sakamoto
  2003-07-04  3:02 ` Kei Sakamoto
@ 2003-07-07 14:19 ` Andrew Cagney
  2003-07-07 18:09   ` Daniel Jacobowitz
  1 sibling, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-07-07 14:19 UTC (permalink / raw)
  To: Kei Sakamoto; +Cc: gdb-patches

> The attached patch fixes gdb.base/bang.exp so that it accepts
> sim's output.
> 
> The current test always fails with sim.
> 
> (gdb) run
> Starting program:
> /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.base/bang!
> 0
> 
> *** EXIT code 0

This is from the test wrapper stuff?  Now that the h8300 is fixed (exits
with proper exit codes), wouldn't it be better to instead just delete
the wrapper stuff from the test framework and make the h8300 a normal
target?

Andrew

> Program exited normally.
> [Switching to process 0]
> (gdb) FAIL: gdb.base/bang.exp: run program (the program exited)




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch/testcase] gdb.base/bang.exp: accespt sim's output
  2003-07-07 14:19 ` Andrew Cagney
@ 2003-07-07 18:09   ` Daniel Jacobowitz
  2003-07-07 18:55     ` Andrew Cagney
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-07-07 18:09 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: Kei Sakamoto, gdb-patches

On Mon, Jul 07, 2003 at 10:19:53AM -0400, Andrew Cagney wrote:
> > The attached patch fixes gdb.base/bang.exp so that it accepts
> > sim's output.
> > 
> > The current test always fails with sim.
> > 
> > (gdb) run
> > Starting program:
> > /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.base/bang!
> > 0
> > 
> > *** EXIT code 0
> 
> This is from the test wrapper stuff?  Now that the h8300 is fixed (exits
> with proper exit codes), wouldn't it be better to instead just delete
> the wrapper stuff from the test framework and make the h8300 a normal
> target?

Well, ARM has the same problem; the trap it uses to report exits by
default doesn't seem to support an exit code.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch/testcase] gdb.base/bang.exp: accespt sim's output
  2003-07-07 18:09   ` Daniel Jacobowitz
@ 2003-07-07 18:55     ` Andrew Cagney
  2003-07-07 19:59       ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-07-07 18:55 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: Kei Sakamoto, gdb-patches

> This is from the test wrapper stuff?  Now that the h8300 is fixed (exits
>> with proper exit codes), wouldn't it be better to instead just delete
>> the wrapper stuff from the test framework and make the h8300 a normal
>> target?
> 
> 
> Well, ARM has the same problem; the trap it uses to report exits by
> default doesn't seem to support an exit code.

That is either a bug in the simulator (or if finally fixed) a bug in the 
test framework.  People kept cloning that wrapper stuff when it wasn't 
needed :-(

Andrew



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch/testcase] gdb.base/bang.exp: accespt sim's output
  2003-07-07 18:55     ` Andrew Cagney
@ 2003-07-07 19:59       ` Daniel Jacobowitz
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-07-07 19:59 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: Kei Sakamoto, gdb-patches

On Mon, Jul 07, 2003 at 02:55:13PM -0400, Andrew Cagney wrote:
> >This is from the test wrapper stuff?  Now that the h8300 is fixed (exits
> >>with proper exit codes), wouldn't it be better to instead just delete
> >>the wrapper stuff from the test framework and make the h8300 a normal
> >>target?
> >
> >
> >Well, ARM has the same problem; the trap it uses to report exits by
> >default doesn't seem to support an exit code.
> 
> That is either a bug in the simulator (or if finally fixed) a bug in the 
> test framework.  People kept cloning that wrapper stuff when it wasn't 
> needed :-(

Well, the bug is the fact that newlib uses the Angel interfaces...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-07-07 19:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-04  2:43 [patch/testcase] gdb.base/bang.exp: accespt sim's output Kei Sakamoto
2003-07-04  3:02 ` Kei Sakamoto
2003-07-07 14:19 ` Andrew Cagney
2003-07-07 18:09   ` Daniel Jacobowitz
2003-07-07 18:55     ` Andrew Cagney
2003-07-07 19:59       ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox