Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <bug-readline@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: [RFA] Fix djgpp gdb-7.4 (and probably trunk) build failure in readline
Date: Sat, 28 Jan 2012 18:19:00 -0000	[thread overview]
Message-ID: <008101ccdde8$d71f84e0$855e8ea0$@muller@ics-cnrs.unistra.fr> (raw)

  Jan Kratochvil suggested me to submit my patch directly to bug-readline
mailing list.

The bug appeared while trying to compile the nw GDB release 7.4
version on a Dos DJGPP target, that does not have
SIGWINCH signal. GDB now uses readline version 6.2,
so this patch is against this version of readline library.

>>>
>>> Starting here is the original post to gdb-patches:
>>>

DJGPP has no SIGWINCH
but despite this being checked by configure,
the code in readline/signal.c
is incompatible with a system that doesn't define SIGWINCH.
I found this problem while trying to compile GDB-7.4 sources for DJGPP.
Trunk source seems to be the same...

I don't know what is the master readline repository...
I am also unsure about proper ChangeLog entry for this...

Pierre Muller
GDB pascal language maintainer

ChangeLog entry:
2012-01-27  Pierre Muller  <muller@ics.u-strasbg.fr>

        * signals.c (_rl_block_sigwinch, _rl_release_sigwinch): Add
        conditional SIGWINCH around functions.

--- readline/signals.c  2011-05-12 01:38:39.000000000 +0200
+++ readline/signals.c.new      2012-01-27 17:47:06.837454200 +0100
@@ -580,6 +580,7 @@ _rl_release_sigint ()
   sigint_blocked = 0;
 }

+#ifdef SIGWINCH
 /* Cause SIGWINCH to not be delivered until the corresponding call to
    release_sigwinch(). */
 void
@@ -627,6 +628,7 @@ _rl_release_sigwinch ()

   sigwinch_blocked = 0;
 }
+#endif /* SIGWINCH */

 /* **************************************************************** */
 /*                                                                 */



             reply	other threads:[~2012-01-28 18:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-28 18:19 Pierre Muller [this message]
2012-02-24 14:19 ` PING " Pierre Muller
     [not found] ` <4f479be7.0610440a.3c16.080cSMTPIN_ADDED@mx.google.com>
2012-02-24 14:41   ` Pedro Alves
2012-02-25 19:59     ` [Bug-readline] " Chet Ramey
2012-02-26 21:54       ` Pierre Muller
     [not found]       ` <4f4943b8.c14eb40a.5ca7.7035SMTPIN_ADDED@mx.google.com>
2012-02-27  3:55         ` Chet Ramey
     [not found] ` <4f479be8.5febd80a.205f.44b6SMTPIN_ADDED@mx.google.com>
2012-02-24 14:51   ` Chet Ramey
2012-02-24 16:01     ` Pierre Muller
     [not found]     ` <4f47b42b.a426440a.768a.685aSMTPIN_ADDED@mx.google.com>
2012-02-24 16:16       ` Pedro Alves
2012-02-24 19:02         ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='008101ccdde8$d71f84e0$855e8ea0$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=bug-readline@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox