From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23707 invoked by alias); 28 Jan 2012 18:16:05 -0000 Received: (qmail 23610 invoked by uid 22791); 28 Jan 2012 18:16:04 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT,TW_DJ,TW_GP,TW_JG X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Jan 2012 18:15:50 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q0SIFdwn047281 ; Sat, 28 Jan 2012 19:15:39 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms5.u-strasbg.fr [130.79.204.14]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id q0SIFcuW041057 ; Sat, 28 Jan 2012 19:15:38 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller ([82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id q0SIFbsC071511 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sat, 28 Jan 2012 19:15:38 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: Subject: [RFA] Fix djgpp gdb-7.4 (and probably trunk) build failure in readline Date: Sat, 28 Jan 2012 18:19:00 -0000 Message-ID: <008101ccdde8$d71f84e0$855e8ea0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00973.txt.bz2 Jan Kratochvil suggested me to submit my patch directly to bug-readline mailing list. The bug appeared while trying to compile the nw GDB release 7.4 version on a Dos DJGPP target, that does not have SIGWINCH signal. GDB now uses readline version 6.2, so this patch is against this version of readline library. >>> >>> Starting here is the original post to gdb-patches: >>> DJGPP has no SIGWINCH but despite this being checked by configure, the code in readline/signal.c is incompatible with a system that doesn't define SIGWINCH. I found this problem while trying to compile GDB-7.4 sources for DJGPP. Trunk source seems to be the same... I don't know what is the master readline repository... I am also unsure about proper ChangeLog entry for this... Pierre Muller GDB pascal language maintainer ChangeLog entry: 2012-01-27 Pierre Muller * signals.c (_rl_block_sigwinch, _rl_release_sigwinch): Add conditional SIGWINCH around functions. --- readline/signals.c 2011-05-12 01:38:39.000000000 +0200 +++ readline/signals.c.new 2012-01-27 17:47:06.837454200 +0100 @@ -580,6 +580,7 @@ _rl_release_sigint () sigint_blocked = 0; } +#ifdef SIGWINCH /* Cause SIGWINCH to not be delivered until the corresponding call to release_sigwinch(). */ void @@ -627,6 +628,7 @@ _rl_release_sigwinch () sigwinch_blocked = 0; } +#endif /* SIGWINCH */ /* **************************************************************** */ /* */