From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Lowercase static function names that use capital letters.
Date: Tue, 19 Apr 2011 11:39:00 -0000 [thread overview]
Message-ID: <007701cbfe86$6f12ffe0$4d38ffa0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <201104191202.36603.pedro@codesourcery.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : mardi 19 avril 2011 13:03
> À : gdb-patches@sourceware.org
> Cc : Pierre Muller
> Objet : Re: [RFA] Lowercase static function names that use capital
letters.
>
> On Tuesday 19 April 2011 11:12:13, Pierre Muller wrote:
> > Is this patch OK or are there any valid reasons to use
> > uppercase function like LM_NEXT?
>
> I think only history, and that nobody ever bothered to lowercase
> them. These started out as macros, and when the macros were
> turned into real functions (when the sunos and svr4 support was
> split out of solib.c, I think), the naming/casing was preserved.
OK, this makes sense indeed.
> > 2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > ARI fixes: Use only lowercase function name for static
functions.
> > * nto-tdep.c (LM_ADDR): Rename to...
> > (lm_addr): New function name.
> > (nto_relocate_section_addresses): Adapt to change above.
> > * solib-sunos.c (LM_ADDR): Rename to...
> > (lm_addr): New function name.
> > (LM_NEXT): Rename to...
> > (lm_next): New function name.
> > (sunos_current_sos, sunos_relocate_section_addresses): Adapt to
> > function name changes above.
> > * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Rename to...
> > (lm_addr_from_link_map): New function name.
> > (HAS_LM_DYNAMIC_FROM_LINK_MAP): Rename to...
> > (has_lm_dynamic_from_link_map): New function name.
> > (LM_DYNAMIC_FROM_LINK_MAP): Rename to...
> > (lm_dynamic_from_link_map): New function name.
> > (LM_ADDR_CHECK): Rename to...
> > (lm_addr_check): New function name.
> > (LM_NEXT): Rename to...
> > (lm_next): New function name.
> > (LM_PREV): Rename to...
> > (lm_prev): New function name.
> > (LM_NAME): Rename to...
> > (lm_name): New function name.
> > (IGNORE_FIRST_LINK_MAP_ENTRY): Rename to...
> > (ignore_first_link_map_entry): New function name.
> > (svr4_keep_data_in_core): Adapt to function name changes above.
> > (svr4_current_sos): Likewise.
> > (enable_break): Likewise.
> > (svr4_relocate_section_addresses): Likewise.
>
> Okay.
Thank you,
patch committed.
Pierre
prev parent reply other threads:[~2011-04-19 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 10:12 Pierre Muller
2011-04-19 11:02 ` Pedro Alves
2011-04-19 11:39 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007701cbfe86$6f12ffe0$4d38ffa0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox