From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26199 invoked by alias); 19 Apr 2011 11:39:47 -0000 Received: (qmail 26189 invoked by uid 22791); 19 Apr 2011 11:39:46 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 11:39:31 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p3JBdQHJ097598 ; Tue, 19 Apr 2011 13:39:26 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms8.u-strasbg.fr [130.79.204.17]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3JBdP48020013 ; Tue, 19 Apr 2011 13:39:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3JBdOSi059380 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 19 Apr 2011 13:39:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: References: <005801cbfe7a$414b24e0$c3e16ea0$@muller@ics-cnrs.unistra.fr> <201104191202.36603.pedro@codesourcery.com> In-Reply-To: <201104191202.36603.pedro@codesourcery.com> Subject: RE: [RFA] Lowercase static function names that use capital letters. Date: Tue, 19 Apr 2011 11:39:00 -0000 Message-ID: <007701cbfe86$6f12ffe0$4d38ffa0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00308.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: mardi 19 avril 2011 13:03 > =C0=A0: gdb-patches@sourceware.org > Cc=A0: Pierre Muller > Objet=A0: Re: [RFA] Lowercase static function names that use capital letters. >=20 > On Tuesday 19 April 2011 11:12:13, Pierre Muller wrote: > > Is this patch OK or are there any valid reasons to use > > uppercase function like LM_NEXT? >=20 > I think only history, and that nobody ever bothered to lowercase > them. These started out as macros, and when the macros were > turned into real functions (when the sunos and svr4 support was > split out of solib.c, I think), the naming/casing was preserved. OK, this makes sense indeed. =20 > > 2011-04-19 Pierre Muller > > > > ARI fixes: Use only lowercase function name for static functions. > > * nto-tdep.c (LM_ADDR): Rename to... > > (lm_addr): New function name. > > (nto_relocate_section_addresses): Adapt to change above. > > * solib-sunos.c (LM_ADDR): Rename to... > > (lm_addr): New function name. > > (LM_NEXT): Rename to... > > (lm_next): New function name. > > (sunos_current_sos, sunos_relocate_section_addresses): Adapt to > > function name changes above. > > * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Rename to... > > (lm_addr_from_link_map): New function name. > > (HAS_LM_DYNAMIC_FROM_LINK_MAP): Rename to... > > (has_lm_dynamic_from_link_map): New function name. > > (LM_DYNAMIC_FROM_LINK_MAP): Rename to... > > (lm_dynamic_from_link_map): New function name. > > (LM_ADDR_CHECK): Rename to... > > (lm_addr_check): New function name. > > (LM_NEXT): Rename to... > > (lm_next): New function name. > > (LM_PREV): Rename to... > > (lm_prev): New function name. > > (LM_NAME): Rename to... > > (lm_name): New function name. > > (IGNORE_FIRST_LINK_MAP_ENTRY): Rename to... > > (ignore_first_link_map_entry): New function name. > > (svr4_keep_data_in_core): Adapt to function name changes above. > > (svr4_current_sos): Likewise. > > (enable_break): Likewise. > > (svr4_relocate_section_addresses): Likewise. >=20 > Okay. Thank you,=20 patch committed. Pierre