From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>, <gdb@sourceware.org>,
"'Eli Zaretskii'" <eliz@gnu.org>
Subject: [RFC] GDB ARIndex Linux rule cleanup
Date: Tue, 14 Apr 2009 23:06:00 -0000 [thread overview]
Message-ID: <007301c9bd55$a66e8320$f34b8960$@u-strasbg.fr> (raw)
In-Reply-To: <20090326230959.GN9472@adacore.com>
Following the discussion about GNU/Linux regressions in
ARI pages, I send this for comment.
Joel told us that all those occurrences should be considered
kernel specific.
I have no opinion directly on the matter, and I only
send this for the ARI to give better results.
Comments welcome,
Pierre Muller
Pascal language support maintainer for GDB
2009-04-15 Pierre Muller <muller.u-strasbg.fr>
ARI fix: GNU/Linux rule in comments.
* amd64-tdep.c (amd64_displaced_step_fixup): Specify Linux kernel.
* i386-tdep.c (i386_displaced_step_fixup): Idem.
* i386-tdep.h (I386_MAX_INSN_LEN): Idem.
* ppc-linux-tdep.c (ppc_linux_supply_gregset): Idem.
(_initialize_ppc_linux_tdep): Idem.
* ppc-linux-tdep.h: Idem.
* linux-nat.c: Idem in starting comments.
(linux_nat_filter_event): Idem.
Index: amd64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-tdep.c,v
retrieving revision 1.58
diff -u -p -r1.58 amd64-tdep.c
--- amd64-tdep.c 17 Feb 2009 06:14:16 -0000 1.58
+++ amd64-tdep.c 14 Apr 2009 22:55:47 -0000
@@ -1273,7 +1273,7 @@ amd64_displaced_step_fixup (struct gdbar
}
/* The list of issues to contend with here is taken from
- resume_execution in arch/x86/kernel/kprobes.c, Linux 2.6.28.
+ resume_execution in arch/x86/kernel/kprobes.c, Linux kernel 2.6.28.
Yay for Free Software! */
/* Relocate the %rip back to the program's instruction stream,
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.269
diff -u -p -r1.269 i386-tdep.c
--- i386-tdep.c 17 Feb 2009 06:14:16 -0000 1.269
+++ i386-tdep.c 14 Apr 2009 22:55:48 -0000
@@ -430,7 +430,7 @@ i386_displaced_step_fixup (struct gdbarc
paddr_nz (from), paddr_nz (to), insn[0], insn[1]);
/* The list of issues to contend with here is taken from
- resume_execution in arch/i386/kernel/kprobes.c, Linux 2.6.20.
+ resume_execution in arch/i386/kernel/kprobes.c, Linux kernel 2.6.20.
Yay for Free Software! */
/* Relocate the %eip, if necessary. */
Index: i386-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.h,v
retrieving revision 1.57
diff -u -p -r1.57 i386-tdep.h
--- i386-tdep.h 4 Feb 2009 14:49:41 -0000 1.57
+++ i386-tdep.h 14 Apr 2009 22:55:48 -0000
@@ -165,7 +165,7 @@ extern struct type *i386_sse_type (struc
#define I386_SEL_KPL 0x0000 /* Kernel Privilige Level. */
/* The length of the longest i386 instruction (according to
- include/asm-i386/kprobes.h in Linux 2.6. */
+ include/asm-i386/kprobes.h in Linux kernel 2.6. */
#define I386_MAX_INSN_LEN (16)
/* Functions exported from i386-tdep.c. */
Index: ppc-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v
retrieving revision 1.110
diff -u -p -r1.110 ppc-linux-tdep.c
--- ppc-linux-tdep.c 22 Feb 2009 01:02:19 -0000 1.110
+++ ppc-linux-tdep.c 14 Apr 2009 22:55:48 -0000
@@ -659,7 +659,7 @@ ppc64_linux_convert_from_func_ptr_addr (
return addr;
}
-/* Wrappers to handle Linux-only registers. */
+/* Wrappers to handle Linux-only kernel registers. */
static void
ppc_linux_supply_gregset (const struct regset *regset,
@@ -1175,7 +1175,7 @@ _initialize_ppc_linux_tdep (void)
gdbarch_register_osabi (bfd_arch_rs6000, bfd_mach_rs6k, GDB_OSABI_LINUX,
ppc_linux_init_abi);
- /* Initialize the Linux target descriptions. */
+ /* Initialize the Linux kernel target descriptions. */
initialize_tdesc_powerpc_32l ();
initialize_tdesc_powerpc_altivec32l ();
initialize_tdesc_powerpc_vsx32l ();
Index: ppc-linux-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-tdep.h,v
retrieving revision 1.4
diff -u -p -r1.4 ppc-linux-tdep.h
--- ppc-linux-tdep.h 3 Jan 2009 05:57:53 -0000 1.4
+++ ppc-linux-tdep.h 14 Apr 2009 22:55:48 -0000
@@ -38,7 +38,7 @@ enum {
/* Return 1 if PPC_ORIG_R3_REGNUM and PPC_TRAP_REGNUM are usable. */
int ppc_linux_trap_reg_p (struct gdbarch *gdbarch);
-/* Linux target descriptions. */
+/* Linux kernel target descriptions. */
extern struct target_desc *tdesc_powerpc_32l;
extern struct target_desc *tdesc_powerpc_altivec32l;
extern struct target_desc *tdesc_powerpc_vsx32l;
Index: linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-nat.c,v
retrieving revision 1.128
diff -u -p -r1.128 linux-nat.c
--- linux-nat.c 1 Apr 2009 19:07:50 -0000 1.128
+++ linux-nat.c 14 Apr 2009 22:55:50 -0000
@@ -70,7 +70,7 @@ When waiting for an event in a specific
the specific pid, and not passing WNOHANG.
When waiting for an event in all threads, waitpid is not quite good. Prior
to
-version 2.4, Linux can either wait for event in main thread, or in
secondary
+version 2.4, Linux kernel can either wait for event in main thread, or in
secondary
threads. (2.4 has the __WALL flag). So, if we use blocking waitpid, we
might
miss an event. The solution is to use non-blocking waitpid, together with
sigsuspend. First, we use non-blocking waitpid to get an event in the main
@@ -2625,7 +2625,7 @@ linux_nat_filter_event (int lwpid, int s
{
/* If this is the main thread, we must stop all threads and verify
if they are still alive. This is because in the nptl thread model
- on Linux 2.4, there is no signal issued for exiting LWPs
+ on Linux kernel 2.4, there is no signal issued for exiting LWPs
other than the main thread. We only get the main thread exit
signal once all child threads have already exited. If we
stop all the threads and use the stop_wait_callback to check
next prev parent reply other threads:[~2009-04-14 23:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 15:29 GDB ARIndex cleanup Pierre Muller
2009-03-26 20:53 ` Eli Zaretskii
2009-03-27 8:23 ` Pierre Muller
2009-03-27 8:47 ` Eli Zaretskii
2009-03-27 14:12 ` Eli Zaretskii
2009-03-27 15:35 ` Eli Zaretskii
2009-04-02 15:12 ` Thiago Jung Bauermann
2009-04-02 19:40 ` Eli Zaretskii
2009-04-02 20:34 ` Joel Brobecker
2009-03-26 23:18 ` Joel Brobecker
2009-03-27 2:22 ` Daniel Jacobowitz
2009-03-27 8:43 ` Pierre Muller
2009-03-27 16:04 ` Joel Brobecker
2009-03-27 16:46 ` Daniel Jacobowitz
2009-04-14 23:06 ` Pierre Muller [this message]
2009-04-14 23:23 ` [RFC] GDB ARIndex Linux rule cleanup Mark Kettenis
2009-04-14 23:38 ` Pedro Alves
2009-04-14 23:41 ` Joel Brobecker
2009-04-15 7:06 ` Pierre Muller
2009-04-15 7:33 ` Eli Zaretskii
2009-04-15 14:00 ` Ulrich Weigand
2009-04-15 14:21 ` Pedro Alves
2009-04-15 15:32 ` Ulrich Weigand
2009-04-15 15:54 ` Pedro Alves
2009-04-15 14:25 ` Eli Zaretskii
2009-04-15 15:15 ` Daniel Jacobowitz
2009-04-15 15:23 ` Ulrich Weigand
2009-04-15 15:34 ` Mark Kettenis
2009-04-15 16:00 ` Eli Zaretskii
2009-04-15 16:04 ` Eli Zaretskii
2009-04-15 17:34 ` Ulrich Weigand
2009-04-15 18:07 ` Eli Zaretskii
2009-04-15 18:55 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007301c9bd55$a66e8320$f34b8960$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox