RE: [RFA] windows-nat.c: Enable processed input at startup

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> >+  std_in_handle = CreateFile ("CONIN$", GENERIC_READ | GENERIC_WRITE,
> >+			      FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0);
> >+
> >+  if (std_in_handle != INVALID_HANDLE_VALUE)
> >+    {
> >+      DWORD console_mode;
> >+      CHECK (GetConsoleMode (std_in_handle, &console_mode));
> >+      console_mode = console_mode | ENABLE_PROCESSED_INPUT;
> >+      CHECK (SetConsoleMode (std_in_handle, console_mode));
> >+    }
> >
> >   init_windows_ops ();
> 
> That has to be conditional on __CYGWIN__ since you'll be screwing up
> Cygwin's
> notion of the console state.

  Is there a Cygwin way to do the same?
 
> And, the name std_in_handle is a misnomer.  It should be console_handle
> or something like that.
 Renamed to conin_handle.
> Can't you just set what you need and close the handle?  I thought this
> setting was global.
  Of course I should close the handle as soon as I changed the
console mode.
  What about this version?

Pierre

2010-04-26  Pierre Muller  <muller@ics.u-strasbg.fr>

	* windows-nat.c (_initialize_windows_nat): Try to set
	ENABLE_PROCESSED_INPUT for console mode if accessible.

Index: windows-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/windows-nat.c,v
retrieving revision 1.208
diff -u -p -r1.208 windows-nat.c
--- windows-nat.c	16 Apr 2010 07:49:35 -0000	1.208
+++ windows-nat.c	26 Apr 2010 15:03:52 -0000
@@ -2357,6 +2357,27 @@ _initialize_windows_nat (void)
 {
   struct cmd_list_element *c;
 
+#ifndef __CYGWIN__
+
+  HANDLE conin_handle;
+
+  /* Try to enable processed input for the console.
+     This should allow to use '^C' to interrupt the debuggee
+     at least as log as the debugge does not modify the
+     console mode settings.  */
+  conin_handle = CreateFile ("CONIN$", GENERIC_READ | GENERIC_WRITE,
+			     FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0);
+
+  if (conin_handle != INVALID_HANDLE_VALUE)
+    {
+      DWORD console_mode;
+      CHECK (GetConsoleMode (conin_handle, &console_mode));
+      console_mode = console_mode | ENABLE_PROCESSED_INPUT;
+      CHECK (SetConsoleMode (conin_handle, console_mode));
+      CHECK (CloseHandle (conin_handle));
+    }
+#endif
+
   init_windows_ops ();
 
 #ifdef __CYGWIN__