From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17203 invoked by alias); 26 Apr 2010 15:07:40 -0000 Received: (qmail 17074 invoked by uid 22791); 26 Apr 2010 15:07:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 15:07:33 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3QF7TmH071211 for ; Mon, 26 Apr 2010 17:07:30 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3QF7TW4096452 for ; Mon, 26 Apr 2010 17:07:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3QF7TLP092298 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Mon, 26 Apr 2010 17:07:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <005401cae535$61adadc0$25090940$@muller@ics-cnrs.unistra.fr> <20100426143241.GB1534@ednor.casa.cgf.cx> In-Reply-To: <20100426143241.GB1534@ednor.casa.cgf.cx> Subject: RE: [RFA] windows-nat.c: Enable processed input at startup Date: Mon, 26 Apr 2010 15:07:00 -0000 Message-ID: <006901cae552$36e27450$a4a75cf0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00872.txt.bz2 > >+ std_in_handle = CreateFile ("CONIN$", GENERIC_READ | GENERIC_WRITE, > >+ FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > >+ > >+ if (std_in_handle != INVALID_HANDLE_VALUE) > >+ { > >+ DWORD console_mode; > >+ CHECK (GetConsoleMode (std_in_handle, &console_mode)); > >+ console_mode = console_mode | ENABLE_PROCESSED_INPUT; > >+ CHECK (SetConsoleMode (std_in_handle, console_mode)); > >+ } > > > > init_windows_ops (); > > That has to be conditional on __CYGWIN__ since you'll be screwing up > Cygwin's > notion of the console state. Is there a Cygwin way to do the same? > And, the name std_in_handle is a misnomer. It should be console_handle > or something like that. Renamed to conin_handle. > Can't you just set what you need and close the handle? I thought this > setting was global. Of course I should close the handle as soon as I changed the console mode. What about this version? Pierre 2010-04-26 Pierre Muller * windows-nat.c (_initialize_windows_nat): Try to set ENABLE_PROCESSED_INPUT for console mode if accessible. Index: windows-nat.c =================================================================== RCS file: /cvs/src/src/gdb/windows-nat.c,v retrieving revision 1.208 diff -u -p -r1.208 windows-nat.c --- windows-nat.c 16 Apr 2010 07:49:35 -0000 1.208 +++ windows-nat.c 26 Apr 2010 15:03:52 -0000 @@ -2357,6 +2357,27 @@ _initialize_windows_nat (void) { struct cmd_list_element *c; +#ifndef __CYGWIN__ + + HANDLE conin_handle; + + /* Try to enable processed input for the console. + This should allow to use '^C' to interrupt the debuggee + at least as log as the debugge does not modify the + console mode settings. */ + conin_handle = CreateFile ("CONIN$", GENERIC_READ | GENERIC_WRITE, + FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); + + if (conin_handle != INVALID_HANDLE_VALUE) + { + DWORD console_mode; + CHECK (GetConsoleMode (conin_handle, &console_mode)); + console_mode = console_mode | ENABLE_PROCESSED_INPUT; + CHECK (SetConsoleMode (conin_handle, console_mode)); + CHECK (CloseHandle (conin_handle)); + } +#endif + init_windows_ops (); #ifdef __CYGWIN__