From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Simplify variable set hooks
Date: Thu, 24 Nov 2016 23:57:00 -0000 [thread overview]
Message-ID: <0065c743-333c-73dc-8ad6-2477aa1e5106@redhat.com> (raw)
In-Reply-To: <1478888325-32039-3-git-send-email-andrew.burgess@embecosm.com>
On 11/11/2016 06:18 PM, Andrew Burgess wrote:
> Now the the variable set-hook mechanism supports automatic rollback of
> the variable value if the set-hook throws an error, simplify existing
> cases where we manually performed roll-back within the set-hook.
Looks good, if we assume we end up agreeing on the previous patch.
Off hand, I recall "set non-stop" and "maint set target-async" as
two other commands that could be simplified.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-11-24 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 18:19 [PATCH 0/2] Auto roll back on error while changing a setting Andrew Burgess
2016-11-11 18:19 ` [PATCH 1/2] gdb: Restore a settings previous value on error during change Andrew Burgess
2016-11-12 0:20 ` Luis Machado
2016-11-15 23:02 ` Andrew Burgess
2016-11-16 14:18 ` Luis Machado
2016-11-16 18:02 ` Andrew Burgess
2016-11-16 18:15 ` Luis Machado
2016-11-24 23:52 ` Pedro Alves
2016-12-29 14:42 ` Andrew Burgess
2016-11-11 18:19 ` [PATCH 2/2] gdb: Simplify variable set hooks Andrew Burgess
2016-11-12 0:29 ` Luis Machado
2016-11-14 8:35 ` Metzger, Markus T
2016-11-24 23:57 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0065c743-333c-73dc-8ad6-2477aa1e5106@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox