From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32897 invoked by alias); 24 Nov 2016 23:57:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32882 invoked by uid 89); 24 Nov 2016 23:57:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=rollback X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 23:57:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F1126AD8; Thu, 24 Nov 2016 23:57:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAONvaxQ017093; Thu, 24 Nov 2016 18:57:36 -0500 Subject: Re: [PATCH 2/2] gdb: Simplify variable set hooks To: Andrew Burgess , gdb-patches@sourceware.org References: <1478888325-32039-1-git-send-email-andrew.burgess@embecosm.com> <1478888325-32039-3-git-send-email-andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: <0065c743-333c-73dc-8ad6-2477aa1e5106@redhat.com> Date: Thu, 24 Nov 2016 23:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478888325-32039-3-git-send-email-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00791.txt.bz2 On 11/11/2016 06:18 PM, Andrew Burgess wrote: > Now the the variable set-hook mechanism supports automatic rollback of > the variable value if the set-hook throws an error, simplify existing > cases where we manually performed roll-back within the set-hook. Looks good, if we assume we end up agreeing on the previous patch. Off hand, I recall "set non-stop" and "maint set target-async" as two other commands that could be simplified. Thanks, Pedro Alves