RE: PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : mercredi 14 novembre 2012 17:46
> À : Pierre Muller
> Cc : 'Pedro Alves'; devans@sourceware.org; gdb-patches@sourceware.org
> Objet : Re: PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012
> 
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
> 
> >> > could you check the patch below
> >> > which removes the new ARI warnings about use of
> >> > xasprintf function in the commit
> >> >
> >> > http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html
> 
> Pierre>   Doug didn't reply yet to this RFA...
> 
> The patch is ok.

Thank for the approval,
I committed the patch.
 
> Tom

While doing so, I noticed that I forgot to
change the date of the ChangeLog entry concerning the MAINTAINER file.
I just changed it to today also...

Pierre Muller
as ARI maintainer


Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14829
diff -u -p -r1.14829 ChangeLog
--- ChangeLog   14 Nov 2012 15:18:02 -0000      1.14829
+++ ChangeLog   15 Nov 2012 08:12:12 -0000
@@ -1,4 +1,11 @@
-2012-11-05  Pierre Muller  <muller@sourceware.org>
+2012-11-15  Pierre Muller  <muller@sourceware.org>
+
+       ARI xasprintf rule fixes.
+       * dwarf2read.c (create_dwo_in_dwp): Use xstrprintf function
+       instead of xasprintf.
+       (open_and_init_dwp_file): Ditto.
+
+2012-11-15  Pierre Muller  <muller@sourceware.org>

        * MAINTAINERS (Responsible Maintainers/misc): Add myself
        as responsible of contrib/ari directory.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.711
diff -u -p -r1.711 dwarf2read.c
--- dwarf2read.c        12 Nov 2012 17:14:54 -0000      1.711
+++ dwarf2read.c        15 Nov 2012 08:12:14 -0000
@@ -8610,13 +8610,14 @@ create_dwo_in_dwp (struct dwp_file *dwp_
      (fewer struct dwo_file objects to allocated).  Remember that for
really
      large apps there can be on the order of 8K CUs and 200K TUs, or more.
*/

-  xasprintf (&virtual_dwo_name, "virtual-dwo/%d-%d-%d-%d",
-            sections.abbrev.asection ? sections.abbrev.asection->id : 0,
-            sections.line.asection ? sections.line.asection->id : 0,
-            sections.loc.asection ? sections.loc.asection->id : 0,
-            (sections.str_offsets.asection
-             ? sections.str_offsets.asection->id
-             : 0));
+  virtual_dwo_name =
+    xstrprintf ("virtual-dwo/%d-%d-%d-%d",
+               sections.abbrev.asection ? sections.abbrev.asection->id : 0,
+               sections.line.asection ? sections.line.asection->id : 0,
+               sections.loc.asection ? sections.loc.asection->id : 0,
+               (sections.str_offsets.asection
+               ? sections.str_offsets.asection->id
+               : 0));
   make_cleanup (xfree, virtual_dwo_name);
   /* Can we use an existing virtual DWO file?  */
   dwo_file_slot = lookup_dwo_file_slot (virtual_dwo_name);
@@ -8982,7 +8983,7 @@ open_and_init_dwp_file (const char *comp
   bfd *dbfd;
   struct cleanup *cleanups;

-  xasprintf (&dwp_name, "%s.dwp", dwarf2_per_objfile->objfile->name);
+  dwp_name = xstrprintf ("%s.dwp", dwarf2_per_objfile->objfile->name);
   cleanups = make_cleanup (xfree, dwp_name);

   dbfd = open_dwop_file (dwp_name, comp_dir, 1);