From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12459 invoked by alias); 15 Nov 2012 08:14:52 -0000 Received: (qmail 12442 invoked by uid 22791); 15 Nov 2012 08:14:48 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT,TW_DW X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 08:14:42 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAF8EZRs097137 ; Thu, 15 Nov 2012 09:14:36 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAF8EZbw000917 ; Thu, 15 Nov 2012 09:14:35 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAF8EYCr008817 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Thu, 15 Nov 2012 09:14:35 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: "'Pedro Alves'" , , References: <20121106015848.GA5296@sourceware.org> <5098efb2.05fd440a.7696.ffffd821SMTPIN_ADDED@mx.google.com> <50995EBB.6070503@redhat.com> <40242.9794231013$1352711862@news.gmane.org> <87obj02kwl.fsf@fleche.redhat.com> In-Reply-To: <87obj02kwl.fsf@fleche.redhat.com> Subject: RE: PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 Date: Thu, 15 Nov 2012 08:14:00 -0000 Message-ID: <005c01cdc309$405114f0$c0f33ed0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00390.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: mercredi 14 novembre 2012 17:46 > =C0=A0: Pierre Muller > Cc=A0: 'Pedro Alves'; devans@sourceware.org; gdb-patches@sourceware.org > Objet=A0: Re: PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > >> > could you check the patch below > >> > which removes the new ARI warnings about use of > >> > xasprintf function in the commit > >> > > >> > http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html >=20 > Pierre> Doug didn't reply yet to this RFA... >=20 > The patch is ok. Thank for the approval, I committed the patch. =20 > Tom While doing so, I noticed that I forgot to change the date of the ChangeLog entry concerning the MAINTAINER file. I just changed it to today also... Pierre Muller as ARI maintainer Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.14829 diff -u -p -r1.14829 ChangeLog --- ChangeLog 14 Nov 2012 15:18:02 -0000 1.14829 +++ ChangeLog 15 Nov 2012 08:12:12 -0000 @@ -1,4 +1,11 @@ -2012-11-05 Pierre Muller +2012-11-15 Pierre Muller + + ARI xasprintf rule fixes. + * dwarf2read.c (create_dwo_in_dwp): Use xstrprintf function + instead of xasprintf. + (open_and_init_dwp_file): Ditto. + +2012-11-15 Pierre Muller * MAINTAINERS (Responsible Maintainers/misc): Add myself as responsible of contrib/ari directory. Index: dwarf2read.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.711 diff -u -p -r1.711 dwarf2read.c --- dwarf2read.c 12 Nov 2012 17:14:54 -0000 1.711 +++ dwarf2read.c 15 Nov 2012 08:12:14 -0000 @@ -8610,13 +8610,14 @@ create_dwo_in_dwp (struct dwp_file *dwp_ (fewer struct dwo_file objects to allocated). Remember that for really large apps there can be on the order of 8K CUs and 200K TUs, or more. */ - xasprintf (&virtual_dwo_name, "virtual-dwo/%d-%d-%d-%d", - sections.abbrev.asection ? sections.abbrev.asection->id : 0, - sections.line.asection ? sections.line.asection->id : 0, - sections.loc.asection ? sections.loc.asection->id : 0, - (sections.str_offsets.asection - ? sections.str_offsets.asection->id - : 0)); + virtual_dwo_name =3D + xstrprintf ("virtual-dwo/%d-%d-%d-%d", + sections.abbrev.asection ? sections.abbrev.asection->id : 0, + sections.line.asection ? sections.line.asection->id : 0, + sections.loc.asection ? sections.loc.asection->id : 0, + (sections.str_offsets.asection + ? sections.str_offsets.asection->id + : 0)); make_cleanup (xfree, virtual_dwo_name); /* Can we use an existing virtual DWO file? */ dwo_file_slot =3D lookup_dwo_file_slot (virtual_dwo_name); @@ -8982,7 +8983,7 @@ open_and_init_dwp_file (const char *comp bfd *dbfd; struct cleanup *cleanups; - xasprintf (&dwp_name, "%s.dwp", dwarf2_per_objfile->objfile->name); + dwp_name =3D xstrprintf ("%s.dwp", dwarf2_per_objfile->objfile->name); cleanups =3D make_cleanup (xfree, dwp_name); dbfd =3D open_dwop_file (dwp_name, comp_dir, 1);