From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Maxim Grigoriev'" <maxim@tensilica.com>,
"'Tom Tromey'" <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA-v2] xtensa-tdep.c ARI fixes
Date: Sat, 16 Apr 2011 16:07:00 -0000 [thread overview]
Message-ID: <005401cbfc50$64efa000$2ecee000$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <4DA89060.9020401@tensilica.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Maxim Grigoriev
> Envoyé : vendredi 15 avril 2011 20:37
> À : Tom Tromey
> Cc : Pierre Muller; gdb-patches@sourceware.org
> Objet : Re: [RFA-v2] xtensa-tdep.c ARI fixes
>
> I tested the patch. No problems have been detected.
> Thanks much for improving Xtensa code.
May I take this as an approval?
> On 04/15/2011 11:21 AM, Tom Tromey wrote:
> >>>>>> "Pierre" == Pierre Muller<pierre.muller@ics-cnrs.unistra.fr>
writes:
> >>>>>>
> > Pierre> Here is a new version that adds this xfree call.
> > Pierre> Could someone test this patch out?
> > Pierre> Again, I have no way to trigger that code, so I can't really
test
> it.
> >
> > The patch looks good to me.
> > But I agree, testing would be nice.
> >
> > Pierre> + && (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
> >
> > Extra space after the "&&" :-)
I am lucky this is not yet tested inside ARI web page...
Otherwise my attempt of getting rid of xtensa-tdep.c source
in the ARI listing would have failed.
Thanks for noticing,
Pierre
next prev parent reply other threads:[~2011-04-16 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15837.6740910628$1302342165@news.gmane.org>
2011-04-14 20:31 ` [RFA] " Tom Tromey
2011-04-15 1:07 ` Maxim Grigoriev
2011-04-15 7:40 ` [RFA-v2] " Pierre Muller
[not found] ` <37948.3434990563$1302853234@news.gmane.org>
2011-04-15 18:22 ` Tom Tromey
2011-04-15 18:37 ` Maxim Grigoriev
2011-04-16 16:07 ` Pierre Muller [this message]
[not found] ` <31380.6117898368$1302970085@news.gmane.org>
2011-04-18 17:07 ` Tom Tromey
2011-04-19 7:18 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005401cbfc50$64efa000$2ecee000$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=maxim@tensilica.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox