From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5874 invoked by alias); 16 Apr 2011 16:07:55 -0000 Received: (qmail 5863 invoked by uid 22791); 16 Apr 2011 16:07:54 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Apr 2011 16:07:41 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p3GG7Xmj020855 ; Sat, 16 Apr 2011 18:07:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3GG7WLW046036 ; Sat, 16 Apr 2011 18:07:33 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3GG7V8O080650 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sat, 16 Apr 2011 18:07:32 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Maxim Grigoriev'" , "'Tom Tromey'" Cc: References: <15837.6740910628$1302342165@news.gmane.org> <37948.3434990563$1302853234@news.gmane.org> <4DA89060.9020401@tensilica.com> In-Reply-To: <4DA89060.9020401@tensilica.com> Subject: RE: [RFA-v2] xtensa-tdep.c ARI fixes Date: Sat, 16 Apr 2011 16:07:00 -0000 Message-ID: <005401cbfc50$64efa000$2ecee000$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00242.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Maxim Grigoriev > Envoy=E9=A0: vendredi 15 avril 2011 20:37 > =C0=A0: Tom Tromey > Cc=A0: Pierre Muller; gdb-patches@sourceware.org > Objet=A0: Re: [RFA-v2] xtensa-tdep.c ARI fixes >=20 > I tested the patch. No problems have been detected. > Thanks much for improving Xtensa code. May I take this as an approval? > On 04/15/2011 11:21 AM, Tom Tromey wrote: > >>>>>> "Pierre" =3D=3D Pierre Muller writes: > >>>>>> > > Pierre> Here is a new version that adds this xfree call. > > Pierre> Could someone test this patch out? > > Pierre> Again, I have no way to trigger that code, so I can't really test > it. > > > > The patch looks good to me. > > But I agree, testing would be nice. > > > > Pierre> + && (i =3D=3D C0_RA || cache->c0.c0_rt[i].fr_reg !=3D C0_RA= ); > > > > Extra space after the "&&" :-) I am lucky this is not yet tested inside ARI web page... Otherwise my attempt of getting rid of xtensa-tdep.c source in the ARI listing would have failed. Thanks for noticing, Pierre