Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] fix cygwin gdb.base/find.exp failures
Date: Mon, 26 Jan 2009 10:32:00 -0000	[thread overview]
Message-ID: <004e01c97fa1$5c878fa0$1596aee0$@u-strasbg.fr> (raw)

  I am still running the testsuite using 
expect version 5.26 from 2003,
because I never managed to get expect 5.43
to run on cygwin... (no more pty available error :( )

  This version has some specific troubles, limitations
or features that make some tests fail using that version
while they should not (or does it have to do with the
tcl version... not really sure, I remember having read once
something about the multiple evaluation differences
for quoted versus braced expressions...).

  gdb.base/find.exp is such an example.

  By a one line patch, I fixed the 17 failures I get otherwise
for this test.

gdb/testsuite/ChangeLog entry:

2009-01-26  Pierre Muller  <muller@ics.u-strasbg.fr>

	* gdb.base/find.exp: Set newline variable
	using quotes instead of braces to fix cygwin failures.



cvs diff -up gdb/testsuite/gdb.base/*
Index: gdb/testsuite/gdb.base/find.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/find.exp,v
retrieving revision 1.4
diff -u -p -r1.4 find.exp
--- gdb/testsuite/gdb.base/find.exp     3 Jan 2009 05:58:03 -0000       1.4
+++ gdb/testsuite/gdb.base/find.exp     26 Jan 2009 10:24:04 -0000
@@ -54,7 +54,7 @@ gdb_expect {

 set hex_number {0x[0-9a-fA-F][0-9a-fA-F]*}
 set history_prefix {[$][0-9]* = }
-set newline {[\r\n]*}
+set newline "\[\r\n\]*"
 set pattern_not_found "${newline}Pattern not found\[.\]"
 set one_pattern_found "${newline}1 pattern found\[.\]"
 set two_patterns_found "${newline}2 patterns found\[.\]"


             reply	other threads:[~2009-01-26 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 10:32 Pierre Muller [this message]
2009-01-26 19:30 ` Doug Evans
2009-01-26 22:41 ` Daniel Jacobowitz
2009-01-27 10:39   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004e01c97fa1$5c878fa0$1596aee0$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox