From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2965 invoked by alias); 26 Jan 2009 10:32:19 -0000 Received: (qmail 2954 invoked by uid 22791); 26 Jan 2009 10:32:18 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_43 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 10:32:12 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n0QAW8Ui004067 for ; Mon, 26 Jan 2009 11:32:08 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms4.u-strasbg.fr [IPv6:2001:660:2402:d::13]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n0QAW8RL028148 for ; Mon, 26 Jan 2009 11:32:08 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n0QAW8Ek014210 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Mon, 26 Jan 2009 11:32:08 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFA] fix cygwin gdb.base/find.exp failures Date: Mon, 26 Jan 2009 10:32:00 -0000 Message-ID: <004e01c97fa1$5c878fa0$1596aee0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00498.txt.bz2 I am still running the testsuite using expect version 5.26 from 2003, because I never managed to get expect 5.43 to run on cygwin... (no more pty available error :( ) This version has some specific troubles, limitations or features that make some tests fail using that version while they should not (or does it have to do with the tcl version... not really sure, I remember having read once something about the multiple evaluation differences for quoted versus braced expressions...). gdb.base/find.exp is such an example. By a one line patch, I fixed the 17 failures I get otherwise for this test. gdb/testsuite/ChangeLog entry: 2009-01-26 Pierre Muller * gdb.base/find.exp: Set newline variable using quotes instead of braces to fix cygwin failures. cvs diff -up gdb/testsuite/gdb.base/* Index: gdb/testsuite/gdb.base/find.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/find.exp,v retrieving revision 1.4 diff -u -p -r1.4 find.exp --- gdb/testsuite/gdb.base/find.exp 3 Jan 2009 05:58:03 -0000 1.4 +++ gdb/testsuite/gdb.base/find.exp 26 Jan 2009 10:24:04 -0000 @@ -54,7 +54,7 @@ gdb_expect { set hex_number {0x[0-9a-fA-F][0-9a-fA-F]*} set history_prefix {[$][0-9]* = } -set newline {[\r\n]*} +set newline "\[\r\n\]*" set pattern_not_found "${newline}Pattern not found\[.\]" set one_pattern_found "${newline}1 pattern found\[.\]" set two_patterns_found "${newline}2 patterns found\[.\]"