RE: [RFA/windows] 64-bit support for x86-64 windows debug registers

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Christopher Faylor
> Envoyé : Friday, January 16, 2009 9:11 PM
> À : gdb-patches@sourceware.org
> Objet : Re: [RFA/windows] 64-bit support for x86-64 windows debug
> registers
> 
> On Fri, Jan 16, 2009 at 11:38:28AM +0100, Pierre Muller wrote:
> >> From Kai Tietz
> >> Hello Pierre,
> >>
> >> for me it worked fine on w64. But of course a maintainer has to give
> >> his
> >> approval for this.
> >
> >  Thus, I resubmit the patch as a RFA.
> >
> >Christopher, is this patch OK?
> >
> >
> >Pierre Muller
> >Pascal language support maintainer for GDB
> >
> >ChangeLog entry:
> >
> >2009-01-14  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> >	* windows-nat.c: Fix debug registers for 64 bits.
> >	(dr): Change type to CORE_ADDR and size to 4.
> >	(dr6, dr7): New variables.
> >	(windows_add_thread, _windows_fetch_inferior_registers)
> >	(windows_continue, do_initial_windows_stuff)
> >	(cygwin_set_dr, cygwin_set_dr7, cygwin_get_dr6): Adapt
> >	to changes above.
> 
> Couldn't we get the same effect by changing
> 
> static unsigned dr[8];
> 
> to
> 
> static uintptr_t dr[8];

  Maybe, but the new types used in my patch exactly match
the static definitions in i386-nat.c:

i386-nat.c:69:#define DR_NADDR  4       /* The number of debug address
registers.  */
i386-nat.c:170:static CORE_ADDR dr_mirror[DR_NADDR];
i386-nat.c:171:static unsigned dr_status_mirror, dr_control_mirror;

  This ensures that there will be no type conversion problems.

Pierre Muller
Pascal language support maintainer for GDB