From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19548 invoked by alias); 19 Jan 2009 08:59:12 -0000 Received: (qmail 19539 invoked by uid 22791); 19 Jan 2009 08:59:11 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Jan 2009 08:59:04 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n0J8x064074180 for ; Mon, 19 Jan 2009 09:59:00 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms4.u-strasbg.fr [IPv6:2001:660:2402:d::13]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n0J8x0TR007612 for ; Mon, 19 Jan 2009 09:59:00 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n0J8x06A025918 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Mon, 19 Jan 2009 09:59:00 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: References: <001401c97656$77a66b70$66f34250$@u-strasbg.fr> <004801c977c6$91f5e110$b5e1a330$@u-strasbg.fr> <20090116201042.GA21690@ednor.casa.cgf.cx> In-Reply-To: <20090116201042.GA21690@ednor.casa.cgf.cx> Subject: RE: [RFA/windows] 64-bit support for x86-64 windows debug registers Date: Mon, 19 Jan 2009 08:59:00 -0000 Message-ID: <003c01c97a14$30a45360$91ecfa20$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00417.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Christopher Faylor > Envoy=E9=A0: Friday, January 16, 2009 9:11 PM > =C0=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA/windows] 64-bit support for x86-64 windows debug > registers >=20 > On Fri, Jan 16, 2009 at 11:38:28AM +0100, Pierre Muller wrote: > >> From Kai Tietz > >> Hello Pierre, > >> > >> for me it worked fine on w64. But of course a maintainer has to give > >> his > >> approval for this. > > > > Thus, I resubmit the patch as a RFA. > > > >Christopher, is this patch OK? > > > > > >Pierre Muller > >Pascal language support maintainer for GDB > > > >ChangeLog entry: > > > >2009-01-14 Pierre Muller > > > > * windows-nat.c: Fix debug registers for 64 bits. > > (dr): Change type to CORE_ADDR and size to 4. > > (dr6, dr7): New variables. > > (windows_add_thread, _windows_fetch_inferior_registers) > > (windows_continue, do_initial_windows_stuff) > > (cygwin_set_dr, cygwin_set_dr7, cygwin_get_dr6): Adapt > > to changes above. >=20 > Couldn't we get the same effect by changing >=20 > static unsigned dr[8]; >=20 > to >=20 > static uintptr_t dr[8]; Maybe, but the new types used in my patch exactly match the static definitions in i386-nat.c: i386-nat.c:69:#define DR_NADDR 4 /* The number of debug address registers. */ i386-nat.c:170:static CORE_ADDR dr_mirror[DR_NADDR]; i386-nat.c:171:static unsigned dr_status_mirror, dr_control_mirror; This ensures that there will be no type conversion problems. Pierre Muller Pascal language support maintainer for GDB