From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Markus Deuling'" <deuling@de.ibm.com>,
"'GDB Patches'" <gdb-patches@sourceware.org>
Cc: "'Ulrich Weigand'" <uweigand@de.ibm.com>
Subject: RE: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c
Date: Thu, 11 Oct 2007 13:36:00 -0000 [thread overview]
Message-ID: <003a01c80bf2$658c64f0$30a52ed0$@u-strasbg.fr> (raw)
In-Reply-To: <470DE4AC.2020101@de.ibm.com>
The patch seems OK, but
I compiled it by applying also the objfiles.c patch
and tried to get the pascal_create_fundamental_type to
be called, and had a hard time finding something
that triggered a call to that function.
I finally found that an untyped real constant in pascal
with stabs debugging worked, and the code seemed to be working
fine.
Thus the pascal patch is approved.
Just a small remark on your ChangeLog:
you forgot the 's' on objfiles.h for the Makefile.in entry.
Pierre Muller
Pascal language maintainer.
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Markus Deuling
> Sent: Thursday, October 11, 2007 10:54 AM
> To: GDB Patches
> Cc: Ulrich Weigand
> Subject: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c
>
> Hi,
>
> this patch gets rid of some of the current_gdbarch's in p-lang.c Is
> this ok to commit?
>
> ChangeLog:
>
>
> * p-lang.c: Add new include objfiles.h.
> (pascal_create_fundamental_type): Use objfile->gdbarch to get
> at the current architecture.
> * Makefile.in (p-lang.o): Add dependency on objfile.h.
>
>
>
> --
> Markus Deuling
> GNU Toolchain for Linux on Cell BE
> deuling@de.ibm.com
>
>
>
prev parent reply other threads:[~2007-10-11 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 8:56 Markus Deuling
2007-10-11 13:36 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003a01c80bf2$658c64f0$30a52ed0$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox