From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 424 invoked by alias); 11 Oct 2007 10:35:02 -0000 Received: (qmail 414 invoked by uid 22791); 11 Oct 2007 10:35:02 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 Oct 2007 10:34:58 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id B4E3B187024; Thu, 11 Oct 2007 12:39:37 +0200 (CEST) From: "Pierre Muller" To: "'Markus Deuling'" , "'GDB Patches'" Cc: "'Ulrich Weigand'" References: <470DE4AC.2020101@de.ibm.com> In-Reply-To: <470DE4AC.2020101@de.ibm.com> Subject: RE: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c Date: Thu, 11 Oct 2007 13:36:00 -0000 Message-ID: <003a01c80bf2$658c64f0$30a52ed0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00279.txt.bz2 The patch seems OK, but I compiled it by applying also the objfiles.c patch and tried to get the pascal_create_fundamental_type to be called, and had a hard time finding something that triggered a call to that function. I finally found that an untyped real constant in pascal with stabs debugging worked, and the code seemed to be working fine. Thus the pascal patch is approved. Just a small remark on your ChangeLog: you forgot the 's' on objfiles.h for the Makefile.in entry. Pierre Muller Pascal language maintainer. > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Markus Deuling > Sent: Thursday, October 11, 2007 10:54 AM > To: GDB Patches > Cc: Ulrich Weigand > Subject: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c > > Hi, > > this patch gets rid of some of the current_gdbarch's in p-lang.c Is > this ok to commit? > > ChangeLog: > > > * p-lang.c: Add new include objfiles.h. > (pascal_create_fundamental_type): Use objfile->gdbarch to get > at the current architecture. > * Makefile.in (p-lang.o): Add dependency on objfile.h. > > > > -- > Markus Deuling > GNU Toolchain for Linux on Cell BE > deuling@de.ibm.com > > >