Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFC] Add hardware breapoints in procfs.c
Date: Thu, 14 May 2009 21:24:00 -0000	[thread overview]
Message-ID: <003701c9d4da$6c4f5fb0$44ee1f10$@u-strasbg.fr> (raw)

I postponed this part of my original patch
for procfs.c

  I don't know if all platforms using
procfs.c code will work with that code,
and I have access only to a i386 OpenSolaris.
 For that target, it works,
but only once the program is started...

 Can someone test other targets?

Pierre

2009-05-14  Pierre Muller  <muller@ics.u-strasbg.fr>

	* procfs.c (procfs_insert_hw_breakpoint,
procfs_remove_hw_breakpoint):
	New functions.
	(procfs_use_watchpoints): Register new hardware breakpoint related
	target functions.

Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.107
diff -u -p -r1.107 procfs.c
--- procfs.c	11 May 2009 11:13:08 -0000	1.107
+++ procfs.c	14 May 2009 20:38:10 -0000
@@ -5348,6 +5348,24 @@ procfs_stopped_by_watchpoint (void)
     }
   return 0;
 }
+/*
+ * Function procfs_stopped_data_address
+ * Returns non-zero if we can find the position
+ * of the triggring watchpoint.
+ */
+
+static int
+procfs_stopped_data_address (struct target_ops *targ, CORE_ADDR *addr)
+{
+  CORE_ADDR waddr;
+
+  if (!procfs_stopped_by_watchpoint ())
+    return 0;
+  waddr = procfs_watchpoint_address ();
+  if (addr)
+    *addr = waddr;
+  return (waddr !== 0);
+}
 
 static int
 procfs_insert_watchpoint (CORE_ADDR addr, int len, int type)
@@ -5387,6 +5405,20 @@ procfs_region_ok_for_hw_watchpoint (CORE
   return 1;
 }
 
+static int
+procfs_insert_hw_breakpoint (struct bp_target_info *bp_tgt)
+{
+  CORE_ADDR addr = bp_tgt->placed_address;
+  return procfs_set_watchpoint (inferior_ptid, addr, 1, hw_execute, 0);
+}
+
+static int
+procfs_remove_hw_breakpoint (struct bp_target_info *bp_tgt)
+{
+  CORE_ADDR addr = bp_tgt->placed_address;
+  return procfs_set_watchpoint (inferior_ptid, addr, 0, 0, 0);
+}
+
 void
 procfs_use_watchpoints (struct target_ops *t)
 {
@@ -5394,6 +5426,9 @@ procfs_use_watchpoints (struct target_op
   t->to_insert_watchpoint = procfs_insert_watchpoint;
   t->to_remove_watchpoint = procfs_remove_watchpoint;
   t->to_region_ok_for_hw_watchpoint = procfs_region_ok_for_hw_watchpoint;
+  t->to_stopped_data_address = procfs_stopped_data_address;
+  t->to_insert_hw_breakpoint = procfs_insert_hw_breakpoint;
+  t->to_remove_hw_breakpoint = procfs_remove_hw_breakpoint;
 }
 
 /*


             reply	other threads:[~2009-05-14 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 21:24 Pierre Muller [this message]
2009-05-14 21:30 ` Pierre Muller
2009-05-15 15:41   ` Joel Brobecker
2009-05-15 15:51     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003701c9d4da$6c4f5fb0$44ee1f10$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox