From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19663 invoked by alias); 14 May 2009 21:24:58 -0000 Received: (qmail 19653 invoked by uid 22791); 14 May 2009 21:24:57 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 May 2009 21:24:52 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4ELOng3039820 for ; Thu, 14 May 2009 23:24:49 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4ELOnM5017628 for ; Thu, 14 May 2009 23:24:49 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4ELOmfB070159 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Thu, 14 May 2009 23:24:49 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFC] Add hardware breapoints in procfs.c Date: Thu, 14 May 2009 21:24:00 -0000 Message-ID: <003701c9d4da$6c4f5fb0$44ee1f10$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00311.txt.bz2 I postponed this part of my original patch for procfs.c I don't know if all platforms using procfs.c code will work with that code, and I have access only to a i386 OpenSolaris. For that target, it works, but only once the program is started... Can someone test other targets? Pierre 2009-05-14 Pierre Muller * procfs.c (procfs_insert_hw_breakpoint, procfs_remove_hw_breakpoint): New functions. (procfs_use_watchpoints): Register new hardware breakpoint related target functions. Index: procfs.c =================================================================== RCS file: /cvs/src/src/gdb/procfs.c,v retrieving revision 1.107 diff -u -p -r1.107 procfs.c --- procfs.c 11 May 2009 11:13:08 -0000 1.107 +++ procfs.c 14 May 2009 20:38:10 -0000 @@ -5348,6 +5348,24 @@ procfs_stopped_by_watchpoint (void) } return 0; } +/* + * Function procfs_stopped_data_address + * Returns non-zero if we can find the position + * of the triggring watchpoint. + */ + +static int +procfs_stopped_data_address (struct target_ops *targ, CORE_ADDR *addr) +{ + CORE_ADDR waddr; + + if (!procfs_stopped_by_watchpoint ()) + return 0; + waddr = procfs_watchpoint_address (); + if (addr) + *addr = waddr; + return (waddr !== 0); +} static int procfs_insert_watchpoint (CORE_ADDR addr, int len, int type) @@ -5387,6 +5405,20 @@ procfs_region_ok_for_hw_watchpoint (CORE return 1; } +static int +procfs_insert_hw_breakpoint (struct bp_target_info *bp_tgt) +{ + CORE_ADDR addr = bp_tgt->placed_address; + return procfs_set_watchpoint (inferior_ptid, addr, 1, hw_execute, 0); +} + +static int +procfs_remove_hw_breakpoint (struct bp_target_info *bp_tgt) +{ + CORE_ADDR addr = bp_tgt->placed_address; + return procfs_set_watchpoint (inferior_ptid, addr, 0, 0, 0); +} + void procfs_use_watchpoints (struct target_ops *t) { @@ -5394,6 +5426,9 @@ procfs_use_watchpoints (struct target_op t->to_insert_watchpoint = procfs_insert_watchpoint; t->to_remove_watchpoint = procfs_remove_watchpoint; t->to_region_ok_for_hw_watchpoint = procfs_region_ok_for_hw_watchpoint; + t->to_stopped_data_address = procfs_stopped_data_address; + t->to_insert_hw_breakpoint = procfs_insert_hw_breakpoint; + t->to_remove_hw_breakpoint = procfs_remove_hw_breakpoint; } /*