Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] ARI fix: remove 6 last %p occurences
Date: Tue, 21 Apr 2009 11:41:00 -0000	[thread overview]
Message-ID: <003301c9c275$f203b060$d60b1120$@u-strasbg.fr> (raw)
In-Reply-To: <m33ac23m79.fsf@fleche.redhat.com>

Thanks for the approval.

I checked the patch in,
but left the two lines together, even if they
do wrap as they are too long in symmisc.c


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Tuesday, April 21, 2009 2:06 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] ARI fix: remove 6 last %p occurences
> 
> >>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
> 
> Pierre>   The two last changes in symmisc.c were postponed
> Pierre> in my first patch because I had a question:
> [...]
> >> I don't know the rules for C,
> >> is an addition of a pointer and a integer always of type pointer?
> Pierre> But nobody answered :(
> 
> Sorry about that.  Yes, in C, the addition of a pointer and an integer
> always has pointer type.
> 
> Pierre> Is this OK?
> 
> Yes, thanks.
> 
> Pierre> +				   host_address_to_string (
> Pierre> +				    psymtab->objfile-
> >global_psymbols.list
> 
> The formatting here looks a bit weird.  There aren't many good
> choices, but usually I just choose to let the line wrap rather than
> splitting after the "(".
> 
> Tom


      reply	other threads:[~2009-04-21 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-18 22:52 Pierre Muller
2009-04-21  0:06 ` Tom Tromey
2009-04-21 11:41   ` Pierre Muller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003301c9c275$f203b060$d60b1120$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox