From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11604 invoked by alias); 21 Apr 2009 11:41:47 -0000 Received: (qmail 11595 invoked by uid 22791); 21 Apr 2009 11:41:47 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_SUB_PCT_LETTER X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Apr 2009 11:41:43 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3LBeCVj075805 ; Tue, 21 Apr 2009 13:40:12 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3LBeCZ1020426 ; Tue, 21 Apr 2009 13:40:12 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3LBeCqZ004287 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 21 Apr 2009 13:40:12 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: References: <003601c9c078$44881fb0$cd985f10$@u-strasbg.fr> In-Reply-To: Subject: RE: [RFA] ARI fix: remove 6 last %p occurences Date: Tue, 21 Apr 2009 11:41:00 -0000 Message-ID: <003301c9c275$f203b060$d60b1120$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00557.txt.bz2 Thanks for the approval. I checked the patch in, but left the two lines together, even if they do wrap as they are too long in symmisc.c Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Tuesday, April 21, 2009 2:06 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] ARI fix: remove 6 last %p occurences >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> The two last changes in symmisc.c were postponed > Pierre> in my first patch because I had a question: > [...] > >> I don't know the rules for C, > >> is an addition of a pointer and a integer always of type pointer? > Pierre> But nobody answered :( >=20 > Sorry about that. Yes, in C, the addition of a pointer and an integer > always has pointer type. >=20 > Pierre> Is this OK? >=20 > Yes, thanks. >=20 > Pierre> + host_address_to_string ( > Pierre> + psymtab->objfile- > >global_psymbols.list >=20 > The formatting here looks a bit weird. There aren't many good > choices, but usually I just choose to let the line wrap rather than > splitting after the "(". >=20 > Tom