From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Cc: "'Pedro Alves'" <pedro@codesourcery.com>
Subject: [PATCH/Obvious] Fix error in last ARI fix for gnu-nat.h
Date: Tue, 21 Apr 2009 11:26:00 -0000 [thread overview]
Message-ID: <002f01c9c274$10a69fc0$31f3df40$@u-strasbg.fr> (raw)
In-Reply-To: <000601c9bf26$50f53740$f2dfa5c0$@u-strasbg.fr>
I missed to add a continuation line in the proc_debug macro in gnu-nat.h
Committed as obvious fix.
I discovered this while looking at the
THREAD_STATE_* macros (listed in ARI).
These macros are all defined only once in
config/i386/nm-i386gnu.h
and used only in gnu-nat.c source
unconditionally. This probably means that gnu hurd can only
be compiled for i386 processor anyhow...
Which in turn, means that we could probably move the stuff
from gnu-nat.c to i386gnu-nat.c
I can send a patch for this, but
I will not be able to test compilation,
as this would require access to gnu HURD.
Pierre Muller
Pascal language support maintainer for GDB
Index: gnu-nat.h
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.h,v
retrieving revision 1.10
diff -u -p -r1.10 gnu-nat.h
--- gnu-nat.h 17 Apr 2009 15:44:28 -0000 1.10
+++ gnu-nat.h 21 Apr 2009 07:29:32 -0000
@@ -89,7 +89,7 @@ extern char *proc_string (struct proc *p
#define proc_debug(_proc, msg, args...) \
do { struct proc *__proc = (_proc); \
debug ("{proc %d/%d %s}: " msg, \
- __proc_pid (__proc), __proc->tid,
+ __proc_pid (__proc), __proc->tid, \
host_address_to_string (__proc) , ##args); } while (0)
extern int gnu_debug_flag;
For info, here is the old wrong patch, that I committed :
> Index: src/gdb/gnu-nat.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/gnu-nat.h,v
> retrieving revision 1.9
> diff -u -p -r1.9 gnu-nat.h
> --- src/gdb/gnu-nat.h 3 Jan 2009 05:57:51 -0000 1.9
> +++ src/gdb/gnu-nat.h 16 Apr 2009 23:42:58 -0000
> @@ -88,8 +88,9 @@ extern char *proc_string (struct proc *p
>
> #define proc_debug(_proc, msg, args...) \
> do { struct proc *__proc = (_proc); \
> - debug ("{proc %d/%d %p}: " msg, \
> - __proc_pid (__proc), __proc->tid, __proc , ##args); } while
> (0)
> + debug ("{proc %d/%d %s}: " msg, \
> + __proc_pid (__proc), __proc->tid,
> + host_address_to_string (__proc) , ##args); } while (0)
>
> extern int gnu_debug_flag;
>
next prev parent reply other threads:[~2009-04-21 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 6:32 [RFA] ARI fix: %p rule Pierre Muller
2009-04-17 13:59 ` Pedro Alves
2009-04-17 15:37 ` Joel Brobecker
2009-04-17 15:54 ` Pierre Muller
2009-04-17 16:00 ` Joel Brobecker
2009-04-17 16:05 ` Pedro Alves
2009-04-21 11:26 ` Pierre Muller [this message]
2009-04-22 18:45 ` [PATCH/Obvious] Fix error in last ARI fix for gnu-nat.h Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01c9c274$10a69fc0$31f3df40$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox