From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7313 invoked by alias); 21 Apr 2009 11:26:57 -0000 Received: (qmail 7300 invoked by uid 22791); 21 Apr 2009 11:26:57 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Apr 2009 11:26:52 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3LBQjug052995 ; Tue, 21 Apr 2009 13:26:45 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3LBQjmA013090 ; Tue, 21 Apr 2009 13:26:45 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3LBQikI097759 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 21 Apr 2009 13:26:45 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: "'Pedro Alves'" References: <000601c9bf26$50f53740$f2dfa5c0$@u-strasbg.fr> In-Reply-To: <000601c9bf26$50f53740$f2dfa5c0$@u-strasbg.fr> Subject: [PATCH/Obvious] Fix error in last ARI fix for gnu-nat.h Date: Tue, 21 Apr 2009 11:26:00 -0000 Message-ID: <002f01c9c274$10a69fc0$31f3df40$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit x-cr-hashedpuzzle: BmpU CZhs De+F HfHR IK0l JG9J JTQ6 JWZN KGfK OINB PRQU RVTt VMm+ Vuj7 WmW5 XMXw;2;ZwBkAGIALQBwAGEAdABjAGgAZQBzAEAAcwBvAHUAcgBjAGUAdwBhAHIAZQAuAG8AcgBnADsAcABlAGQAcgBvAEAAYwBvAGQAZQBzAG8AdQByAGMAZQByAHkALgBjAG8AbQA=;Sosha1_v1;7;{3AC9212A-7AA1-475C-8173-907B4B8F2C43};bQB1AGwAbABlAHIAQABpAGMAcwAuAHUALQBzAHQAcgBhAHMAYgBnAC4AZgByAA==;Tue, 21 Apr 2009 11:26:44 GMT;WwBQAEEAVABDAEgALwBPAGIAdgBpAG8AdQBzAF0AIABGAGkAeAAgAGUAcgByAG8AcgAgAGkAbgAgAGwAYQBzAHQAIABBAFIASQAgAGYAaQB4ACAAZgBvAHIAIABnAG4AdQAtAG4AYQB0AC4AaAA= x-cr-puzzleid: {3AC9212A-7AA1-475C-8173-907B4B8F2C43} Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00556.txt.bz2 I missed to add a continuation line in the proc_debug macro in gnu-nat.h Committed as obvious fix. I discovered this while looking at the THREAD_STATE_* macros (listed in ARI). These macros are all defined only once in config/i386/nm-i386gnu.h and used only in gnu-nat.c source unconditionally. This probably means that gnu hurd can only be compiled for i386 processor anyhow... Which in turn, means that we could probably move the stuff from gnu-nat.c to i386gnu-nat.c I can send a patch for this, but I will not be able to test compilation, as this would require access to gnu HURD. Pierre Muller Pascal language support maintainer for GDB Index: gnu-nat.h =================================================================== RCS file: /cvs/src/src/gdb/gnu-nat.h,v retrieving revision 1.10 diff -u -p -r1.10 gnu-nat.h --- gnu-nat.h 17 Apr 2009 15:44:28 -0000 1.10 +++ gnu-nat.h 21 Apr 2009 07:29:32 -0000 @@ -89,7 +89,7 @@ extern char *proc_string (struct proc *p #define proc_debug(_proc, msg, args...) \ do { struct proc *__proc = (_proc); \ debug ("{proc %d/%d %s}: " msg, \ - __proc_pid (__proc), __proc->tid, + __proc_pid (__proc), __proc->tid, \ host_address_to_string (__proc) , ##args); } while (0) extern int gnu_debug_flag; For info, here is the old wrong patch, that I committed : > Index: src/gdb/gnu-nat.h > =================================================================== > RCS file: /cvs/src/src/gdb/gnu-nat.h,v > retrieving revision 1.9 > diff -u -p -r1.9 gnu-nat.h > --- src/gdb/gnu-nat.h 3 Jan 2009 05:57:51 -0000 1.9 > +++ src/gdb/gnu-nat.h 16 Apr 2009 23:42:58 -0000 > @@ -88,8 +88,9 @@ extern char *proc_string (struct proc *p > > #define proc_debug(_proc, msg, args...) \ > do { struct proc *__proc = (_proc); \ > - debug ("{proc %d/%d %p}: " msg, \ > - __proc_pid (__proc), __proc->tid, __proc , ##args); } while > (0) > + debug ("{proc %d/%d %s}: " msg, \ > + __proc_pid (__proc), __proc->tid, > + host_address_to_string (__proc) , ##args); } while (0) > > extern int gnu_debug_flag; >