From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <elena.zannoni@oracle.com>
Cc: "'gdb-patches ml'" <gdb-patches@sourceware.org>,
"'Jonas Maebe'" <jonas.maebe@elis.ugent.be>
Subject: [RFA] dwarf2read pascal language char recognition.
Date: Tue, 10 Feb 2009 15:14:00 -0000 [thread overview]
Message-ID: <002901c98b92$18d94cb0$4a8be610$@u-strasbg.fr> (raw)
Jonas Maebe pointed me to a pascal specific error
in dwarf2read code.
This patch sets TYPE_CODE for
DW_ATE_signed_char and DW_ATE_unsigned_char
to TYPE_CODE_CHAR in case of Pascal (rather than only for Ada and Modula-2).
This could almost go in as obvious, but
I still prefer to ask for your approval.
Is it OK to check this in?
Pierre Muller
Pascal language support maintainer for GDB
2009-02-10 Pierre Muller <muller@ics.u-strasbg.fr>
* dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR
for DW_ATE_signed_char and DW_ATE_unisgned_char
for pascal language.
Index: gdb/dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.293
diff -u -p -r1.293 dwarf2read.c
--- gdb/dwarf2read.c 9 Feb 2009 00:07:53 -0000 1.293
+++ gdb/dwarf2read.c 10 Feb 2009 15:03:07 -0000
@@ -5098,11 +5098,13 @@ read_base_type (struct die_info *die, st
type_flags |= TYPE_FLAG_UNSIGNED;
break;
case DW_ATE_signed_char:
- if (cu->language == language_ada || cu->language == language_m2)
+ if (cu->language == language_ada || cu->language == language_m2
+ || cu->language == language_pascal)
code = TYPE_CODE_CHAR;
break;
case DW_ATE_unsigned_char:
- if (cu->language == language_ada || cu->language == language_m2)
+ if (cu->language == language_ada || cu->language == language_m2
+ || cu->language == language_pascal)
code = TYPE_CODE_CHAR;
type_flags |= TYPE_FLAG_UNSIGNED;
break;
next reply other threads:[~2009-02-10 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 15:14 Pierre Muller [this message]
2009-02-11 18:56 ` Joel Brobecker
2009-02-11 22:31 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002901c98b92$18d94cb0$4a8be610$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=elena.zannoni@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=jonas.maebe@elis.ugent.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox