From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12677 invoked by alias); 10 Feb 2009 15:14:10 -0000 Received: (qmail 12562 invoked by uid 22791); 10 Feb 2009 15:14:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Feb 2009 15:14:05 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n1AFDEab065478 ; Tue, 10 Feb 2009 16:13:14 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n1AFDE9w001124 ; Tue, 10 Feb 2009 16:13:14 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n1AFDEs3097018 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 10 Feb 2009 16:13:14 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: "'gdb-patches ml'" , "'Jonas Maebe'" Subject: [RFA] dwarf2read pascal language char recognition. Date: Tue, 10 Feb 2009 15:14:00 -0000 Message-ID: <002901c98b92$18d94cb0$4a8be610$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00222.txt.bz2 Jonas Maebe pointed me to a pascal specific error in dwarf2read code. This patch sets TYPE_CODE for DW_ATE_signed_char and DW_ATE_unsigned_char to TYPE_CODE_CHAR in case of Pascal (rather than only for Ada and Modula-2). This could almost go in as obvious, but I still prefer to ask for your approval. Is it OK to check this in? Pierre Muller Pascal language support maintainer for GDB 2009-02-10 Pierre Muller * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR for DW_ATE_signed_char and DW_ATE_unisgned_char for pascal language. Index: gdb/dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.293 diff -u -p -r1.293 dwarf2read.c --- gdb/dwarf2read.c 9 Feb 2009 00:07:53 -0000 1.293 +++ gdb/dwarf2read.c 10 Feb 2009 15:03:07 -0000 @@ -5098,11 +5098,13 @@ read_base_type (struct die_info *die, st type_flags |= TYPE_FLAG_UNSIGNED; break; case DW_ATE_signed_char: - if (cu->language == language_ada || cu->language == language_m2) + if (cu->language == language_ada || cu->language == language_m2 + || cu->language == language_pascal) code = TYPE_CODE_CHAR; break; case DW_ATE_unsigned_char: - if (cu->language == language_ada || cu->language == language_m2) + if (cu->language == language_ada || cu->language == language_m2 + || cu->language == language_pascal) code = TYPE_CODE_CHAR; type_flags |= TYPE_FLAG_UNSIGNED; break;