From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Cc: "'Joel Brobecker'" <brobecker@adacore.com>
Subject: RE: Explanation: New ARI warning Wed Apr 21 01:54:25 UTC 2010
Date: Wed, 21 Apr 2010 08:01:00 -0000 [thread overview]
Message-ID: <002701cae128$d5819060$8084b120$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <001801cae125$cac33230$60499690$@muller@ics-cnrs.unistra.fr>
Whoops, I forgot ONE big limitation
that might apply to today's email.
> > 1072a1071
> > > gdb/procfs.c:4090: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:4090: sprintf (name, ', pi->pid, map->pr_mapname);
> > 1100d1098
> > < gdb/procfs.c:5659: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:5659: sprintf (name, ', pi->pid, map->pr_mapname);
I wasn't careful enough:
The first 1072 is with '>' meaning new,
but the second is '<' meaning removal.
Moreover the two lines are identical which probably means that
this is just due to reordering.
Thus the total number of 'sprintf' uses did not change
but the reordering of the functions that Joel
made lead to this email.
My apologies to Joel.
So this reveals already a limitation
of the script: If you move function around,
it becomes difficult to realize for the script that this is
only a move, and no new warning.
Sorry for my wrong first explanation,
Pierre
next prev parent reply other threads:[~2010-04-21 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 1:54 GDB Administrator
2010-04-21 7:40 ` Explanation: " Pierre Muller
2010-04-21 8:01 ` Pierre Muller [this message]
2010-04-21 14:22 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701cae128$d5819060$8084b120$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox