From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72353-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30458 invoked by alias); 21 Apr 2010 08:01:49 -0000
Received: (qmail 30168 invoked by uid 22791); 21 Apr 2010 08:01:45 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 08:01:41 +0000
Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41])            by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3L811hx056448            ; Wed, 21 Apr 2010 10:01:02 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12])            by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3L811l3033857            ; Wed, 21 Apr 2010 10:01:01 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)           by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3L811js070986 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO)           ; Wed, 21 Apr 2010 10:01:01 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Cc: "'Joel Brobecker'" <brobecker@adacore.com>
References: <20100421015425.GA10145@sourceware.org> <001801cae125$cac33230$60499690$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <001801cae125$cac33230$60499690$@muller@ics-cnrs.unistra.fr>
Subject: RE: Explanation: New ARI warning Wed Apr 21 01:54:25 UTC 2010
Date: Wed, 21 Apr 2010 08:01:00 -0000
Message-ID: <002701cae128$d5819060$8084b120$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00672.txt.bz2

  Whoops, I forgot ONE big limitation
that might apply to today's email.

> > 1072a1071
> > > gdb/procfs.c:4090: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:4090:      sprintf (name, ', pi->pid, map->pr_mapname);
> > 1100d1098
> > < gdb/procfs.c:5659: code: sprintf: Do not use sprintf, instead use
> > xstrprintf
> > gdb/procfs.c:5659:      sprintf (name, ', pi->pid, map->pr_mapname);

   I wasn't careful enough:
The first 1072 is with '>' meaning new,
but the second is '<' meaning removal.
  Moreover the two lines are identical which probably means that
this is just due to reordering.

  Thus the total number of 'sprintf' uses did not change
but the reordering of the functions that Joel
made lead to this email.

  My apologies to Joel.

  So this reveals already a limitation
of the script: If you move function around, 
it becomes difficult to realize for the script that this is 
only a move, and no new warning.

  Sorry for my wrong first explanation,


Pierre