From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: RE: [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess
Date: Mon, 14 Jan 2008 08:03:00 -0000 [thread overview]
Message-ID: <002701c85683$d8a055b0$89e10110$@u-strasbg.fr> (raw)
In-Reply-To: <20080111183146.GA27708@ednor.casa.cgf.cx>
> No need to apologize! I'm glad you caught this and I'm glad that you
> researched your earlier changes. I actually stumbled across your
> initial bug separately last week while debugging something with an
> older
> version of gdb. So, I'm happy that you fixed it.
>
> >ChangeLog entry:
> >
> >2008-01-11 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > * win32-nat.c (win32_create_inferior): Restore
> > code calling CloseHandle on ProcessInformation structure.
>
> Please check in. I'm sorry that I didn't catch this when I reviewed
> your change. It's obvious in perfect 20-20 hindsight.
Done, thanks,
Pierre Muller
prev parent reply other threads:[~2008-01-14 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 17:21 Pierre Muller
2008-01-11 18:32 ` Christopher Faylor
2008-01-14 8:03 ` Pierre Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701c85683$d8a055b0$89e10110$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox