From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20706 invoked by alias); 14 Jan 2008 08:03:04 -0000 Received: (qmail 20694 invoked by uid 22791); 14 Jan 2008 08:03:03 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jan 2008 08:02:43 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id 377C618701A for ; Mon, 14 Jan 2008 09:06:26 +0100 (CET) From: "Pierre Muller" To: References: <001301c85476$4eff2fc0$ecfd8f40$@u-strasbg.fr> <20080111183146.GA27708@ednor.casa.cgf.cx> In-Reply-To: <20080111183146.GA27708@ednor.casa.cgf.cx> Subject: RE: [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess Date: Mon, 14 Jan 2008 08:03:00 -0000 Message-ID: <002701c85683$d8a055b0$89e10110$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00324.txt.bz2 > No need to apologize! I'm glad you caught this and I'm glad that you > researched your earlier changes. I actually stumbled across your > initial bug separately last week while debugging something with an > older > version of gdb. So, I'm happy that you fixed it. > > >ChangeLog entry: > > > >2008-01-11 Pierre Muller > > > > * win32-nat.c (win32_create_inferior): Restore > > code calling CloseHandle on ProcessInformation structure. > > Please check in. I'm sorry that I didn't catch this when I reviewed > your change. It's obvious in perfect 20-20 hindsight. Done, thanks, Pierre Muller