[patch][testsuite,arm] Fix .global directives in gdb.arch/arm-disp-step.S

[patch][testsuite,arm] Fix .global directives in gdb.arch/arm-disp-step.S

[Greta Yorsh]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

The test gdb.arch/arm-disp-step.S fails with an assembler error, as a result
of a change to reading symbol names made by:
http://sourceware.org/ml/binutils-cvs/2012-05/msg00199.html

This patch fixes the use of .global directives in gdb.arch/arm-disp-step.S
by inserting the missing labels.

Thanks,
Greta

2012-06-14  Greta Yorsh  <Greta.Yorsh@arm.com>

	* gdb.arch/arm-disp-step.S: Fix use of .global directives.


[-- Attachment #2: test-gdb-disp-step.patch.txt --]
[-- Type: text/plain, Size: 819 bytes --]

diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.S b/gdb/testsuite/gdb.arch/arm-disp-step.S
index 423edc0..09d1663 100644
--- a/gdb/testsuite/gdb.arch/arm-disp-step.S
+++ b/gdb/testsuite/gdb.arch/arm-disp-step.S
@@ -110,7 +110,7 @@ test_ret:
 	.type test_branch, %function
 test_branch:
 	b	L_branch
-	.global
+	.global L_branch
 L_branch:
 	bx lr
 	.size test_branch, .-test_branch
@@ -124,7 +124,7 @@ L_branch:
 test_ldr_pc:
 	ldr	r1, [pc, #0]
 
-	.global
+	.global test_ldr_pc_ret
 test_ldr_pc_ret:
 	bx lr
 	.size test_ldr_pc, .-test_ldr_pc
@@ -137,10 +137,10 @@ test_ldm_stm_pc:
 	ldmia	sp!, {r0, r1}
 	ldr	r0, .L1
 	stmdb	sp!, {r0}
-	.global
+	.global test_ldm_pc
 test_ldm_pc:
 	ldmia	sp!, {pc}
-	.global
+	.global test_ldm_stm_pc_ret
 test_ldm_stm_pc_ret:
 	bx lr
 	.align	2

RE: [patch][testsuite,arm] Fix .global directives in gdb.arch/arm-disp-step.S

[Greta Yorsh]

Ping?
http://sourceware.org/ml/gdb-patches/2012-06/msg00582.html

Thanks,
Greta

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Greta Yorsh
> Sent: 18 June 2012 16:33
> To: gdb-patches@sourceware.org
> Cc: Richard Earnshaw
> Subject: [patch][testsuite,arm] Fix .global directives in gdb.arch/arm-
> disp-step.S
> 
> The test gdb.arch/arm-disp-step.S fails with an assembler error, as a
> result
> of a change to reading symbol names made by:
> http://sourceware.org/ml/binutils-cvs/2012-05/msg00199.html
> 
> This patch fixes the use of .global directives in gdb.arch/arm-disp-
> step.S
> by inserting the missing labels.
> 
> Thanks,
> Greta
> 
> 2012-06-14  Greta Yorsh  <Greta.Yorsh@arm.com>
> 
> 	* gdb.arch/arm-disp-step.S: Fix use of .global directives.

Re: [patch][testsuite,arm] Fix .global directives in gdb.arch/arm-disp-step.S

[Richard Earnshaw]

On 18/06/12 16:33, Greta Yorsh wrote:
> The test gdb.arch/arm-disp-step.S fails with an assembler error, as a result
> of a change to reading symbol names made by:
> http://sourceware.org/ml/binutils-cvs/2012-05/msg00199.html
> 
> This patch fixes the use of .global directives in gdb.arch/arm-disp-step.S
> by inserting the missing labels.
> 
> Thanks,
> Greta
> 
> 2012-06-14  Greta Yorsh  <Greta.Yorsh@arm.com>
> 
> 	* gdb.arch/arm-disp-step.S: Fix use of .global directives.
> 
> 

OK.

R.