From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>,
"'Eli Zaretskii'" <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFC] win32-nat.c: Improve handling of 'set shell on'
Date: Thu, 10 Jan 2008 08:58:00 -0000 [thread overview]
Message-ID: <001601c85366$edf49d60$c9ddd820$@u-strasbg.fr> (raw)
In-Reply-To: <20080109200334.GH21281@adacore.com>
Joel is right,
I just sent the patch with that line so that
by just applying the patch,
someone could really test the effect of the patch.
If you remove that line, the default stays to
not use shell, and thus running the testsuite
does not show any change, as there are no tests
using 'set shell on'.
In fact, as Daniel explained in his first
answer to this thread, it is possible to
run the testsuite with
make check "RUNTESTFLAGS=GDBFLAGS=\"--nx -ex 'set shell on'\""
which removes the need of changing the default value
to useshell static variable.
Anyhow, this is only a RFC.
Christopher, do you want me to resend another RFC
or will you give your comments on that one?
Pierre
next prev parent reply other threads:[~2008-01-10 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 9:05 Pierre Muller
2008-01-09 12:45 ` Daniel Jacobowitz
2008-01-09 18:56 ` Eli Zaretskii
2008-01-09 20:04 ` Joel Brobecker
2008-01-10 8:58 ` Pierre Muller [this message]
2008-01-10 1:53 ` Christopher Faylor
2008-01-10 4:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001601c85366$edf49d60$c9ddd820$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox