From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31911 invoked by alias); 10 Jan 2008 08:58:47 -0000 Received: (qmail 31901 invoked by uid 22791); 10 Jan 2008 08:58:46 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 10 Jan 2008 08:58:18 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id 2FFD018701C; Thu, 10 Jan 2008 10:02:04 +0100 (CET) From: "Pierre Muller" To: "'Joel Brobecker'" , "'Eli Zaretskii'" Cc: References: <000001c8529e$a8088460$f8198d20$@u-strasbg.fr> <20080109200334.GH21281@adacore.com> In-Reply-To: <20080109200334.GH21281@adacore.com> Subject: RE: [RFC] win32-nat.c: Improve handling of 'set shell on' Date: Thu, 10 Jan 2008 08:58:00 -0000 Message-ID: <001601c85366$edf49d60$c9ddd820$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00229.txt.bz2 Joel is right, I just sent the patch with that line so that by just applying the patch, someone could really test the effect of the patch. If you remove that line, the default stays to not use shell, and thus running the testsuite does not show any change, as there are no tests using 'set shell on'. In fact, as Daniel explained in his first answer to this thread, it is possible to run the testsuite with make check "RUNTESTFLAGS=GDBFLAGS=\"--nx -ex 'set shell on'\"" which removes the need of changing the default value to useshell static variable. Anyhow, this is only a RFC. Christopher, do you want me to resend another RFC or will you give your comments on that one? Pierre