RE: New ARI warning Sat Feb 9 02:05:37 UTC 2013 in -D 2013-02-09-gmt

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

0a1,10
> gdb/aarch64-linux-nat.c:146: code: long long: Do not use 'long long',
instead use LONGEST
gdb/aarch64-linux-nat.c:146:typedef unsigned long long dr_changed_t;
> gdb/aarch64-linux-nat.c:338: code: %ll: Do not use printf(%ll), instead
use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:338:			  "\tpid%d,
dr_changed_bp=0x%llx, "
> gdb/aarch64-linux-nat.c:339: code: %ll: Do not use printf(%ll), instead
use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:339:			  "dr_changed_wp=0x%llx\n",
> gdb/aarch64-linux-nat.c:364: code: %ll: Do not use printf(%ll), instead
use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:364:			  "\tOn exit:\n\tpid%d,
dr_changed_bp=0x%llx, "
> gdb/aarch64-linux-nat.c:365: code: %ll: Do not use printf(%ll), instead
use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:365:			  "dr_changed_wp=0x%llx\n",

  I already proposed once to add a distinction between native files,
for which I would suppress those kind of warnings.

> gdb/aarch64-linux-nat.c:736: gettext: _ markup: All messages should be
marked up with _.
gdb/aarch64-linux-nat.c:736:	  warning ("Unexpected number of hardware
watchpoint registers reported"
> gdb/aarch64-linux-nat.c:744: gettext: _ markup: All messages should be
marked up with _.
gdb/aarch64-linux-nat.c:744:      warning ("Unable to determine the number
of hardware watchpoints"
> gdb/aarch64-linux-nat.c:756: gettext: _ markup: All messages should be
marked up with _.
gdb/aarch64-linux-nat.c:756:	  warning ("Unexpected number of hardware
breakpoint registers reported"
> gdb/aarch64-linux-nat.c:764: gettext: _ markup: All messages should be
marked up with _.
gdb/aarch64-linux-nat.c:764:      warning ("Unable to determine the number
of hardware breakpoints"

  Those _("..") should indeed be added.

> gdb/aarch64-linux-tdep.c:39: comment: GNU/Linux: Do not use 'Linux',
instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate between the two (this test assumes that word 'Linux' appears
on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/aarch64-linux-tdep.c:39:   and PSTATE registers, as defined in the
AArch64 port of the Linux

  This is a clear case on false warning,
as the word 'kernel' appears just at the next line....

  I suspect that we should merge the whole comment into a single line before

applying this rule (and probably others related to comments...


Pierre Muller
as ARI maintainer.