From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 516 invoked by alias); 9 Feb 2013 09:01:03 -0000 Received: (qmail 488 invoked by uid 22791); 9 Feb 2013 09:01:02 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Feb 2013 09:00:39 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1990aeE065312 for ; Sat, 9 Feb 2013 10:00:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms11.u-strasbg.fr [130.79.204.111]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1990XWs014901 for ; Sat, 9 Feb 2013 10:00:33 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1990ZnB025259 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sat, 9 Feb 2013 10:00:36 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <20130209020537.GA20140@sourceware.org> In-Reply-To: <20130209020537.GA20140@sourceware.org> Subject: RE: New ARI warning Sat Feb 9 02:05:37 UTC 2013 in -D 2013-02-09-gmt Date: Sat, 09 Feb 2013 09:01:00 -0000 Message-ID: <001501ce06a3$ed646a60$c82d3f20$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00236.txt.bz2 0a1,10 > gdb/aarch64-linux-nat.c:146: code: long long: Do not use 'long long', instead use LONGEST gdb/aarch64-linux-nat.c:146:typedef unsigned long long dr_changed_t; > gdb/aarch64-linux-nat.c:338: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/aarch64-linux-nat.c:338: "\tpid%d, dr_changed_bp=0x%llx, " > gdb/aarch64-linux-nat.c:339: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/aarch64-linux-nat.c:339: "dr_changed_wp=0x%llx\n", > gdb/aarch64-linux-nat.c:364: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/aarch64-linux-nat.c:364: "\tOn exit:\n\tpid%d, dr_changed_bp=0x%llx, " > gdb/aarch64-linux-nat.c:365: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value gdb/aarch64-linux-nat.c:365: "dr_changed_wp=0x%llx\n", I already proposed once to add a distinction between native files, for which I would suppress those kind of warnings. > gdb/aarch64-linux-nat.c:736: gettext: _ markup: All messages should be marked up with _. gdb/aarch64-linux-nat.c:736: warning ("Unexpected number of hardware watchpoint registers reported" > gdb/aarch64-linux-nat.c:744: gettext: _ markup: All messages should be marked up with _. gdb/aarch64-linux-nat.c:744: warning ("Unable to determine the number of hardware watchpoints" > gdb/aarch64-linux-nat.c:756: gettext: _ markup: All messages should be marked up with _. gdb/aarch64-linux-nat.c:756: warning ("Unexpected number of hardware breakpoint registers reported" > gdb/aarch64-linux-nat.c:764: gettext: _ markup: All messages should be marked up with _. gdb/aarch64-linux-nat.c:764: warning ("Unable to determine the number of hardware breakpoints" Those _("..") should indeed be added. > gdb/aarch64-linux-tdep.c:39: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version gdb/aarch64-linux-tdep.c:39: and PSTATE registers, as defined in the AArch64 port of the Linux This is a clear case on false warning, as the word 'kernel' appears just at the next line.... I suspect that we should merge the whole comment into a single line before applying this rule (and probably others related to comments... Pierre Muller as ARI maintainer.