Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Remove AC_HEADER_STAT from configure.ac
Date: Thu, 15 Nov 2012 14:59:00 -0000	[thread overview]
Message-ID: <001501cdc341$bc181d80$34485880$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <50A4FD68.5080006@redhat.com>

> >   I tried...
> > Here is the result.
> >   Should we add stat.h to the list of checked headers?
> 
> No need.  gdb_stat.h includes sys/stat.h unconditionally.
> 
> > I didn't find any HAVE_STAT_H occurrence,
> > and thus assumed this was unnecessary.
> 
> > PS: In the regenerated files,
> > I discovered that configure has a strange, apparently unrelated
> > change... Is this normal?
> 
> No.  I just tried regenerating configure in the current
> mainline, with no changes to configure.ac, and configure
> did not change for me.  Be sure to use pristine FSF autoconf 2.64.
> Sounds like the autoconf you used has local mingw patches.
> 
> > 2012-11-15  Pierre Muller  <muller@sourceware.org>
> >
> >         * configure.ac (AC_HEADER_STAT): Remove.
> >         * gdb_stat.h (STAT_MACROS_BROKEN): Remove macro use
> >         and corresponding code.
> >         * configure: Regenerate.
> 
> Otherwise this is fine.  Thanks.
I just manually removed the unwanted change to configure and
committed the rest.

Thanks for the approval,

Pierre



  reply	other threads:[~2012-11-15 14:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50a4aadb.c54c420a.715f.5d53SMTPIN_ADDED@mx.google.com>
2012-11-15 10:15 ` [RFA] ARI fixes: move gdb_stat.h and gdb_wait.h to common subdirectory Pedro Alves
2012-11-15 14:24   ` [RFA] Remove AC_HEADER_STAT from configure.ac Pierre Muller
2012-11-15 14:34     ` Pedro Alves
2012-11-15 14:59       ` Pierre Muller [this message]
2012-11-15 15:55   ` [RFA-v2] ARI fixes: move gdb_stat.h and gdb_wait.h to common subdirectory Pierre Muller
     [not found]   ` <50a51072.c4c5440a.2696.ffffd0acSMTPIN_ADDED@mx.google.com>
2012-11-15 16:02     ` Pedro Alves
2012-11-15 16:14       ` Pierre Muller
     [not found]   ` <22837.8922366121$1352989522@news.gmane.org>
2012-11-15 16:07     ` [RFA] Remove AC_HEADER_STAT from configure.ac Tom Tromey
2012-11-15 16:09       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001501cdc341$bc181d80$34485880$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox