From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95964-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20939 invoked by alias); 15 Nov 2012 14:59:26 -0000
Received: (qmail 20929 invoked by uid 22791); 15 Nov 2012 14:59:25 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 14:59:01 +0000
Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFEwudJ072929           ; Thu, 15 Nov 2012 15:58:56 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms13.u-strasbg.fr [130.79.204.113])          by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFEwtXs023370          ; Thu, 15 Nov 2012 15:58:56 +0100
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAFEwswT023169 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Thu, 15 Nov 2012 15:58:54 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
References: <50a4aadb.c54c420a.715f.5d53SMTPIN_ADDED@mx.google.com> <50A4C0C5.8020901@redhat.com> <000301cdc33c$f4203d20$dc60b760$@muller@ics-cnrs.unistra.fr> <50A4FD68.5080006@redhat.com>
In-Reply-To: <50A4FD68.5080006@redhat.com>
Subject: RE: [RFA] Remove AC_HEADER_STAT from configure.ac
Date: Thu, 15 Nov 2012 14:59:00 -0000
Message-ID: <001501cdc341$bc181d80$34485880$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00402.txt.bz2

> >   I tried...
> > Here is the result.
> >   Should we add stat.h to the list of checked headers?
> 
> No need.  gdb_stat.h includes sys/stat.h unconditionally.
> 
> > I didn't find any HAVE_STAT_H occurrence,
> > and thus assumed this was unnecessary.
> 
> > PS: In the regenerated files,
> > I discovered that configure has a strange, apparently unrelated
> > change... Is this normal?
> 
> No.  I just tried regenerating configure in the current
> mainline, with no changes to configure.ac, and configure
> did not change for me.  Be sure to use pristine FSF autoconf 2.64.
> Sounds like the autoconf you used has local mingw patches.
> 
> > 2012-11-15  Pierre Muller  <muller@sourceware.org>
> >
> >         * configure.ac (AC_HEADER_STAT): Remove.
> >         * gdb_stat.h (STAT_MACROS_BROKEN): Remove macro use
> >         and corresponding code.
> >         * configure: Regenerate.
> 
> Otherwise this is fine.  Thanks.
I just manually removed the unwanted change to configure and
committed the rest.

Thanks for the approval,

Pierre