From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Cc: "'Eli Zaretskii'" <eliz@gnu.org>
Subject: [RFC] Question about CODESET macro inside config/djgpp/langinfo.h
Date: Mon, 21 Mar 2011 16:27:00 -0000 [thread overview]
Message-ID: <000c01cbe7e0$53e3f510$fbabdf30$@muller@ics-cnrs.unistra.fr> (raw)
Also about macros removal inside config subdirectory:
I was wondering about the usefulness of CODESET macro definition
inside
config/djgpp/langinfo.h
#define CODESET CODESET
while CODESET is itself a member of an enumeration.
Albeit harmless, this is listed as a macro to remove...
I don't see any code testing for the presence of this macro.
The configure script should work unchanged if we remove that line, no?
I also looked into config/djgpp/djconfig.sh
and I don't see where it could trigger any change.
Any objection to remove that macro?
Pierre Muller
Changelog entry:
2011-03-21 Pierre Muller <muller@ics.u-strasbg.fr>
* config/djgpp/langinfo.h (CODESET macro): Remove.
Pierre@E6510-Muller ~/git/archer
$ git diff gdb/config/djgpp
diff --git a/gdb/config/djgpp/langinfo.h b/gdb/config/djgpp/langinfo.h
index d3a5672..a624f78 100644
--- a/gdb/config/djgpp/langinfo.h
+++ b/gdb/config/djgpp/langinfo.h
@@ -28,8 +28,6 @@ enum {
_NL_NUM
};
-#define CODESET CODESET
-
extern char *nl_langinfo (nl_item);
#endif /* _LANGINFO_H */
next reply other threads:[~2011-03-21 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 16:27 Pierre Muller [this message]
2011-03-21 16:53 ` Mark Kettenis
2011-03-21 17:25 ` Pierre Muller
2011-03-21 20:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01cbe7e0$53e3f510$fbabdf30$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox