From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20048 invoked by alias); 21 Mar 2011 15:55:15 -0000 Received: (qmail 19959 invoked by uid 22791); 21 Mar 2011 15:55:14 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_20,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 15:55:05 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2LFsxpx050211 ; Mon, 21 Mar 2011 16:54:59 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2LFsw9b049959 ; Mon, 21 Mar 2011 16:54:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2LFsw9R007471 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 21 Mar 2011 16:54:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: "'Eli Zaretskii'" Subject: [RFC] Question about CODESET macro inside config/djgpp/langinfo.h Date: Mon, 21 Mar 2011 16:27:00 -0000 Message-ID: <000c01cbe7e0$53e3f510$fbabdf30$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00961.txt.bz2 Also about macros removal inside config subdirectory: I was wondering about the usefulness of CODESET macro definition inside config/djgpp/langinfo.h #define CODESET CODESET while CODESET is itself a member of an enumeration. Albeit harmless, this is listed as a macro to remove... I don't see any code testing for the presence of this macro. The configure script should work unchanged if we remove that line, no? I also looked into config/djgpp/djconfig.sh and I don't see where it could trigger any change. Any objection to remove that macro? Pierre Muller Changelog entry: 2011-03-21 Pierre Muller * config/djgpp/langinfo.h (CODESET macro): Remove. Pierre@E6510-Muller ~/git/archer $ git diff gdb/config/djgpp diff --git a/gdb/config/djgpp/langinfo.h b/gdb/config/djgpp/langinfo.h index d3a5672..a624f78 100644 --- a/gdb/config/djgpp/langinfo.h +++ b/gdb/config/djgpp/langinfo.h @@ -28,8 +28,6 @@ enum { _NL_NUM }; -#define CODESET CODESET - extern char *nl_langinfo (nl_item); #endif /* _LANGINFO_H */