* [RFA] AR Index: Add exceptions for gnulib/string.in.h
@ 2009-03-23 23:14 Pierre Muller
2009-03-23 23:36 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Pierre Muller @ 2009-03-23 23:14 UTC (permalink / raw)
To: gdb-patches
2 strdup and 2 strerror failures listed in
AR Index are due to code in gnulib/string.in.h
header.
This code inserts a linking time warning
so I suppose that it can be added to the list of
occurrences that can be ignored.
Commit log:
* Add exceptions for gnulib/string.in.h
for 2 strdup and 2 strerror occurrences.
Is this OK?
Pierre Muller
Pascal language support maintainer for GDB
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.80
diff -u -p -r1.80 gdb_ari.sh
--- gdb_ari.sh 23 Mar 2009 14:38:19 -0000 1.80
+++ gdb_ari.sh 23 Mar 2009 22:46:00 -0000
@@ -498,6 +498,7 @@ Do not use &&, or || at the end of a lin
BEGIN { doc["strerror"] = "\
Do not use strerror(), instead use safe_strerror()"
category["strerror"] = ari_regression
+ fix("strerror", "gdb/gnulib/string.in.h", 2)
fix("strerror", "gdb/gdb_string.h", 1)
fix("strerror", "gdb/mingw-hdep.c", 1)
fix("strerror", "gdb/posix-hdep.c", 1)
@@ -1336,6 +1337,7 @@ Do not use strdup(), instead use xstrdup
category["strdup"] = ari_regression
}
/(^|[^_[:alnum:]])strdup[[:space:]]*\(/ {
+ fix("strdup", "gdb/gnulib/string.in.h", 2)
fail("strdup")
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] AR Index: Add exceptions for gnulib/string.in.h
2009-03-23 23:14 [RFA] AR Index: Add exceptions for gnulib/string.in.h Pierre Muller
@ 2009-03-23 23:36 ` Joel Brobecker
2009-03-24 0:00 ` Pierre Muller
2009-03-24 1:27 ` [RFA] AR Index: Add exceptions for gnulib/string.in.h Tom Tromey
0 siblings, 2 replies; 6+ messages in thread
From: Joel Brobecker @ 2009-03-23 23:36 UTC (permalink / raw)
To: Pierre Muller; +Cc: gdb-patches
> 2 strdup and 2 strerror failures listed in
> AR Index are due to code in gnulib/string.in.h
> header.
gnulib is imported code - does it really make sense to run the ARI on it?
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFA] AR Index: Add exceptions for gnulib/string.in.h
2009-03-23 23:36 ` Joel Brobecker
@ 2009-03-24 0:00 ` Pierre Muller
2009-03-24 2:44 ` Joel Brobecker
2009-03-24 1:27 ` [RFA] AR Index: Add exceptions for gnulib/string.in.h Tom Tromey
1 sibling, 1 reply; 6+ messages in thread
From: Pierre Muller @ 2009-03-24 0:00 UTC (permalink / raw)
To: 'Joel Brobecker'; +Cc: gdb-patches
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Tuesday, March 24, 2009 12:23 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] AR Index: Add exceptions for gnulib/string.in.h
>
> > 2 strdup and 2 strerror failures listed in
> > AR Index are due to code in gnulib/string.in.h
> > header.
>
> gnulib is imported code - does it really make sense to run the ARI on
> it?
Maybe not,
in that case we should probably just remove that sub-directory from the
listing of the inspected files.
This can be done by adding
a simple line in gdb_find.sh
-name gnulib -prune -o \
Would that be a better change?
Pierre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] AR Index: Add exceptions for gnulib/string.in.h
2009-03-24 0:00 ` Pierre Muller
@ 2009-03-24 2:44 ` Joel Brobecker
2009-03-24 7:22 ` [PATCH] AR Index: Ignore gnulib directory Pierre Muller
0 siblings, 1 reply; 6+ messages in thread
From: Joel Brobecker @ 2009-03-24 2:44 UTC (permalink / raw)
To: Pierre Muller; +Cc: gdb-patches
> This can be done by adding a simple line in gdb_find.sh
>
> -name gnulib -prune -o \
>
> Would that be a better change?
Yes - that would seem like the right thing to do (thanks for you
feedback, Tom!). Go ahead and commit that change. I don' think
that other maintainers will want us to check these files against
the ARI, but it's always easy to undo that change if some do.
Can you also post the patch you ended up checking in, just for
the record?
Thanks,
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] AR Index: Ignore gnulib directory
2009-03-24 2:44 ` Joel Brobecker
@ 2009-03-24 7:22 ` Pierre Muller
0 siblings, 0 replies; 6+ messages in thread
From: Pierre Muller @ 2009-03-24 7:22 UTC (permalink / raw)
To: 'Joel Brobecker'; +Cc: gdb-patches
I committed this with the following commit message:
* gdb_find.sh: Ignore gnulib files as they are imported.
Thanks for the approval, Joel.
Pierre Muller
Pascal language support maintainer for GDB
$ cvs diff -up gdb_find.sh
Index: gdb_find.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v
retrieving revision 1.11
diff -u -p -r1.11 gdb_find.sh
--- gdb_find.sh 24 Oct 2007 20:24:55 -0000 1.11
+++ gdb_find.sh 24 Mar 2009 07:09:46 -0000
@@ -6,6 +6,7 @@ find "$@" \
-name signals -prune -o \
-name testsuite -prune -o \
-name gdbserver -prune -o \
+ -name gnulib -prune -o \
-name rdi-share -prune -o \
-name osf-share -prune -o \
-name nlm -prune -o \
> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : Tuesday, March 24, 2009 3:40 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] AR Index: Add exceptions for gnulib/string.in.h
>
> > This can be done by adding a simple line in gdb_find.sh
> >
> > -name gnulib -prune -o \
> >
> > Would that be a better change?
>
> Yes - that would seem like the right thing to do (thanks for you
> feedback, Tom!). Go ahead and commit that change. I don' think
> that other maintainers will want us to check these files against
> the ARI, but it's always easy to undo that change if some do.
>
> Can you also post the patch you ended up checking in, just for
> the record?
>
> Thanks,
> --
> Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] AR Index: Add exceptions for gnulib/string.in.h
2009-03-23 23:36 ` Joel Brobecker
2009-03-24 0:00 ` Pierre Muller
@ 2009-03-24 1:27 ` Tom Tromey
1 sibling, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2009-03-24 1:27 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Pierre Muller, gdb-patches
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> 2 strdup and 2 strerror failures listed in
>> AR Index are due to code in gnulib/string.in.h
>> header.
Joel> gnulib is imported code - does it really make sense to run the
Joel> ARI on it?
IMO, no.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-24 7:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-23 23:14 [RFA] AR Index: Add exceptions for gnulib/string.in.h Pierre Muller
2009-03-23 23:36 ` Joel Brobecker
2009-03-24 0:00 ` Pierre Muller
2009-03-24 2:44 ` Joel Brobecker
2009-03-24 7:22 ` [PATCH] AR Index: Ignore gnulib directory Pierre Muller
2009-03-24 1:27 ` [RFA] AR Index: Add exceptions for gnulib/string.in.h Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox