[RFA] darwin-nat.c AR Index fixes: remove strerror uses

[RFA] darwin-nat.c AR Index fixes: remove strerror uses

[Pierre Muller]

  This patch could be consider 
under the obvious rule,
but as it is a native file, I still wanted to
get an approval from someone 'who knows'...

  But I didn't find anyone in MAINTAINERS
for the darwin* files...

  Is this OK  to check in?


Pierre Muller
Pascal language support maintainer for GDB


2009-03-24  Pierre Muller  <muller@ics.u-strasbg.fr>

	ARI fix.
	* darwin-nat.c (darwin_ptrace): Use safe_strerror.
	(darwin_stop_inferior, darwin_attach, darwin_detach): Ditto.
 

Index: gdb/darwin-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/darwin-nat.c,v
retrieving revision 1.6
diff -u -p -r1.6 darwin-nat.c
--- gdb/darwin-nat.c    16 Mar 2009 15:57:08 -0000      1.6
+++ gdb/darwin-nat.c    23 Mar 2009 22:57:05 -0000
@@ -242,7 +242,7 @@ darwin_ptrace (const char *name,

   inferior_debug (2, _("ptrace (%s, %d, 0x%x, %d): %d (%s)\n"),
                   name, pid, arg3, arg4, ret,
-                  (ret != 0) ? strerror (errno) : _("no error"));
+                  (ret != 0) ? safe_strerror (errno) : _("no error"));
   return ret;
 }

@@ -686,7 +686,7 @@ darwin_stop_inferior (struct target_ops

   res = kill (inf->pid, SIGSTOP);
   if (res != 0)
-    warning (_("cannot kill: %s\n"), strerror (errno));
+    warning (_("cannot kill: %s\n"), safe_strerror (errno));

   ptid = darwin_wait (ops, inferior_ptid, &wstatus);
   gdb_assert (wstatus.kind = TARGET_WAITKIND_STOPPED);
@@ -964,7 +964,7 @@ darwin_attach (struct target_ops *ops, c
   res = PTRACE (PT_ATTACHEXC, pid, 0, 0);
   if (res != 0)
     error (_("Unable to attach to process-id %d: %s (%d)"),
-          pid, strerror (errno), errno);
+          pid, safe_strerror (errno), errno);

   inf = add_inferior (pid);
   inf->attach_flag = 1;
@@ -1028,7 +1028,7 @@ darwin_detach (struct target_ops *ops, c
   res = PTRACE (PT_DETACH, darwin_inf->pid, 0, 0);
   if (res != 0)
     printf_unfiltered (_("Unable to detach from process-id %d: %s (%d)"),
-                      darwin_inf->pid, strerror (errno), errno);
+                      darwin_inf->pid, safe_strerror (errno), errno);

   msg_state = NO_MESSAGE;

Re: [RFA] darwin-nat.c AR Index fixes: remove strerror uses

[Joel Brobecker]

>   This patch could be consider under the obvious rule,

I would agree with that.

> but as it is a native file, I still wanted to
> get an approval from someone 'who knows'...

I could double-check by rebuilding that file on one of our MacOS
machines, I suppose, but the change is mechanical and small enough
that a second pair of eyes should be enough.

> 2009-03-24  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	ARI fix.
> 	* darwin-nat.c (darwin_ptrace): Use safe_strerror.
> 	(darwin_stop_inferior, darwin_attach, darwin_detach): Ditto.

OK.

-- 
Joel