Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Daniel Jacobowitz'" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFC] gnu-nat.c: possibly fix "info threads" test failures
Date: Thu, 19 Jun 2008 18:58:00 -0000	[thread overview]
Message-ID: <000401c8d229$d5daaf70$81900e50$@u-strasbg.fr> (raw)
In-Reply-To: <20080619135632.GB16956@caradoc.them.org>

Here you are:
but as I said, I cannot even compile
gdb that is using this... far less
run the testsuite.
 There might also be some specific test that,
on the contrary relies on the lower case "thread"
to pass.

  Anyhow, I am willing to commit this
if anyone either tests it or takes the
responsibility to accept it without testing...


Pierre Muller
Pascal language support maintainer for GDB



ChangeLog entry:

2008-12-19  Pierre Muller  <muller@ics.u-strasbg.fr>

        * gnu-nat.c (proc_string): Use capital T for "Thread".



$ cat gnu-nat-thread.patch
Index: gdb/gnu-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.c,v
retrieving revision 1.46
diff -u -p -r1.46 gnu-nat.c
--- gdb/gnu-nat.c       1 Jan 2008 22:53:10 -0000       1.46
+++ gdb/gnu-nat.c       19 Jun 2008 16:24:36 -0000
@@ -2556,7 +2556,7 @@ proc_string (struct proc *proc)
   if (proc_is_task (proc))
     sprintf (tid_str, "process %d", proc->inf->pid);
   else
-    sprintf (tid_str, "thread %d.%d",
+    sprintf (tid_str, "Thread %d.%d",
             proc->inf->pid, pid_to_thread_id (MERGEPID (proc->tid, 0)));
   return tid_str;
 }


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Daniel Jacobowitz
> Envoyé : Thursday, June 19, 2008 3:57 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFC] win32-nat.c: fix "info threads" test failures
> 
> On Thu, Jun 19, 2008 at 08:43:09AM +0200, Pierre Muller wrote:
> > Thanks,
> > committed now.
> >
> > Should I submit a similar patch for gnu-nat.c?
> > The main problem is that I have no way to
> > run a testsuite that would use the modified code...
> 
> I think you should go ahead.
> 
> --
> Daniel Jacobowitz
> CodeSourcery



  reply	other threads:[~2008-06-19 16:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19  3:54 [RFC] win32-nat.c: " Pierre Muller
2008-06-19  4:38 ` Christopher Faylor
2008-06-19 10:23   ` Pierre Muller
2008-06-19 18:57     ` Daniel Jacobowitz
2008-06-19 18:58       ` Pierre Muller [this message]
2008-06-19 20:35         ` [RFC] gnu-nat.c: possibly " Joel Brobecker
2008-06-20 14:30           ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000401c8d229$d5daaf70$81900e50$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox