From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10448 invoked by alias); 19 Jun 2008 16:31:36 -0000 Received: (qmail 10432 invoked by uid 22791); 19 Jun 2008 16:31:33 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 19 Jun 2008 16:30:53 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m5JGUl2K058670 ; Thu, 19 Jun 2008 18:30:47 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402::142]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m5JGUl9M076630 ; Thu, 19 Jun 2008 18:30:47 +0200 (CEST) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) by mailserver.u-strasbg.fr (8.13.8/jtpda-5.5pre1) with ESMTP id m5JGUii6065602 ; Thu, 19 Jun 2008 18:30:47 +0200 (CEST) From: "Pierre Muller" To: "'Daniel Jacobowitz'" Cc: References: <000001c8d19f$a7c3a040$f74ae0c0$@u-strasbg.fr> <20080619035356.GA23549@ednor.casa.cgf.cx> <000c01c8d1d7$bcd1a990$3674fcb0$@u-strasbg.fr> <20080619135632.GB16956@caradoc.them.org> In-Reply-To: <20080619135632.GB16956@caradoc.them.org> Subject: RE: [RFC] gnu-nat.c: possibly fix "info threads" test failures Date: Thu, 19 Jun 2008 18:58:00 -0000 Message-ID: <000401c8d229$d5daaf70$81900e50$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::157]); Thu, 19 Jun 2008 18:30:47 +0200 (CEST) X-Virus-Status: Clean Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00354.txt.bz2 Here you are: but as I said, I cannot even compile gdb that is using this... far less run the testsuite. There might also be some specific test that, on the contrary relies on the lower case "thread" to pass. Anyhow, I am willing to commit this if anyone either tests it or takes the responsibility to accept it without testing... Pierre Muller Pascal language support maintainer for GDB ChangeLog entry: 2008-12-19 Pierre Muller * gnu-nat.c (proc_string): Use capital T for "Thread". $ cat gnu-nat-thread.patch Index: gdb/gnu-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/gnu-nat.c,v retrieving revision 1.46 diff -u -p -r1.46 gnu-nat.c --- gdb/gnu-nat.c 1 Jan 2008 22:53:10 -0000 1.46 +++ gdb/gnu-nat.c 19 Jun 2008 16:24:36 -0000 @@ -2556,7 +2556,7 @@ proc_string (struct proc *proc) if (proc_is_task (proc)) sprintf (tid_str, "process %d", proc->inf->pid); else - sprintf (tid_str, "thread %d.%d", + sprintf (tid_str, "Thread %d.%d", proc->inf->pid, pid_to_thread_id (MERGEPID (proc->tid, 0))); return tid_str; } > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Daniel Jacobowitz > Envoy=E9=A0: Thursday, June 19, 2008 3:57 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC] win32-nat.c: fix "info threads" test failures >=20 > On Thu, Jun 19, 2008 at 08:43:09AM +0200, Pierre Muller wrote: > > Thanks, > > committed now. > > > > Should I submit a similar patch for gnu-nat.c? > > The main problem is that I have no way to > > run a testsuite that would use the modified code... >=20 > I think you should go ahead. >=20 > -- > Daniel Jacobowitz > CodeSourcery