From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: [RFA-v2] Fix cygwin compilation failure for python code
Date: Tue, 09 Mar 2010 14:52:00 -0000 [thread overview]
Message-ID: <000201cabf98$13907950$3ab16bf0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <m34okqww5h.fsf@fleche.redhat.com>
> Pierre> I wonder why I am the only one having this
> Pierre> problem?
>
> Me too.
Glad to hear that I am not the only one ...
> Pierre> Is this patch OK? Otherwise,
> Pierre> how should such problems be handled?
>
> I would recommend just including symtab.h from python-internal.h.
You are right, this is easier,
but I was suspecting that the
original writers of this header
wanted it to NOT depend on any real gdb header...
Anyway, here is a new version of the
compilation failure fix.
Python is not even mentioned in MAINTAINERS...
Is this version OK?
Pierre Muller
gdb/ChangeLog entry:
2010-03-09 Pierre Muller <muller@ics.u-strasbg.fr>
* python/python-internal.h: Include symtab.h.
Index: python-internal.h
===================================================================
RCS file: /cvs/src/src/gdb/python/python-internal.h,v
retrieving revision 1.21
diff -u -p -r1.21 python-internal.h
--- python-internal.h 24 Feb 2010 21:18:27 -0000 1.21
+++ python-internal.h 9 Mar 2010 14:44:56 -0000
@@ -61,9 +61,11 @@ typedef int Py_ssize_t;
#define PyEval_ReleaseLock() 0
#endif
+/* In order to be able to parse symtab_and_line_to_sal_object function
+ a real symtab_and_line structure is needed. */
+#include "symtab.h"
+
struct block;
-struct symbol;
-struct symtab_and_line;
struct value;
struct language_defn;
next prev parent reply other threads:[~2010-03-09 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <14243.7868555591$1268066303@news.gmane.org>
2010-03-08 17:39 ` [RFA] " Tom Tromey
2010-03-09 14:52 ` Pierre Muller [this message]
2010-03-09 17:02 ` [RFA-v2] " Tom Tromey
2010-03-09 17:14 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201cabf98$13907950$3ab16bf0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox