From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2478 invoked by alias); 9 Mar 2010 14:52:21 -0000 Received: (qmail 2468 invoked by uid 22791); 9 Mar 2010 14:52:21 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Mar 2010 14:52:15 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id o29Eptbg070587 ; Tue, 9 Mar 2010 15:51:55 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o29EpsIh033739 ; Tue, 9 Mar 2010 15:51:54 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o29EpsAO014022 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 9 Mar 2010 15:51:54 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: References: <14243.7868555591$1268066303@news.gmane.org> In-Reply-To: Subject: [RFA-v2] Fix cygwin compilation failure for python code Date: Tue, 09 Mar 2010 14:52:00 -0000 Message-ID: <000201cabf98$13907950$3ab16bf0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00353.txt.bz2 > Pierre> I wonder why I am the only one having this > Pierre> problem? > > Me too. Glad to hear that I am not the only one ... > Pierre> Is this patch OK? Otherwise, > Pierre> how should such problems be handled? > > I would recommend just including symtab.h from python-internal.h. You are right, this is easier, but I was suspecting that the original writers of this header wanted it to NOT depend on any real gdb header... Anyway, here is a new version of the compilation failure fix. Python is not even mentioned in MAINTAINERS... Is this version OK? Pierre Muller gdb/ChangeLog entry: 2010-03-09 Pierre Muller * python/python-internal.h: Include symtab.h. Index: python-internal.h =================================================================== RCS file: /cvs/src/src/gdb/python/python-internal.h,v retrieving revision 1.21 diff -u -p -r1.21 python-internal.h --- python-internal.h 24 Feb 2010 21:18:27 -0000 1.21 +++ python-internal.h 9 Mar 2010 14:44:56 -0000 @@ -61,9 +61,11 @@ typedef int Py_ssize_t; #define PyEval_ReleaseLock() 0 #endif +/* In order to be able to parse symtab_and_line_to_sal_object function + a real symtab_and_line structure is needed. */ +#include "symtab.h" + struct block; -struct symbol; -struct symtab_and_line; struct value; struct language_defn;