[RFA] handle DW_AT_byte_size for set types

[RFA] handle DW_AT_byte_size for set types

[Pierre Muller]

  According to Dwarf 2.0.0 page 46,
DW_TAG_set_type
supports DW_AT_byte_size attribute,
but this is not implemented yet inside GDB.

  The patch below implements this,
it will allow to correctly give the value of 
constant pascal sets (at least for Free Pascal compiler).

  The patch is rather obvious...
Is this OK?

Pierre Muller
Pascal language support maintainer for GDB


 
2010-05-17  Pierre Muller  <muller@ics.u-strasbg.fr>

	* dwarf2read.c (read_set_type): Set type length if
	DW_AT_byte_size attribute is present.

Index: src/gdb/dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.385
diff -u -p -r1.385 dwarf2read.c
--- src/gdb/dwarf2read.c	14 May 2010 17:53:16 -0000	1.385
+++ src/gdb/dwarf2read.c	17 May 2010 15:33:17 -0000
@@ -5547,7 +5556,10 @@ static struct type *
 read_set_type (struct die_info *die, struct dwarf2_cu *cu)
 {
   struct type *set_type = create_set_type (NULL, die_type (die, cu));
+  struct attribute *attr = dwarf2_attr (die, DW_AT_byte_size, cu);
 
+  if (attr)
+    TYPE_LENGTH(set_type) = DW_UNSND (attr);
   return set_die_type (die, set_type, cu);
 }
 

Re: [RFA] handle DW_AT_byte_size for set types

[Joel Brobecker]

> 2010-05-17  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* dwarf2read.c (read_set_type): Set type length if
> 	DW_AT_byte_size attribute is present.

Looks good to me too.

-- 
Joel

RE: [RFA] handle DW_AT_byte_size for set types

[Pierre Muller]

> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : Monday, May 17, 2010 5:47 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] handle DW_AT_byte_size for set types
> 
> > 2010-05-17  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> > 	* dwarf2read.c (read_set_type): Set type length if
> > 	DW_AT_byte_size attribute is present.
> 
> Looks good to me too.

  Thanks, applied... after modification
according to Tom's email about the missing space.

Pierre

Re: [RFA] handle DW_AT_byte_size for set types

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> +    TYPE_LENGTH(set_type) = DW_UNSND (attr);

Missing space before the first "(".

Tom