Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: [RFA] Testsuite: Remove obsolete match_max uses
Date: Tue, 06 Oct 2009 14:46:00 -0000	[thread overview]
Message-ID: <000001ca4693$7a8e1870$6faa4950$@u-strasbg.fr> (raw)
In-Reply-To: <20091002232011.GH10338@adacore.com>

  I've checked in the patch.

> > PS1: If this is approved, we should also
> > consider what to do about the three tests
> > that set another value of match_max
> > (lower than the 30000).
> 
> We should simply remove them, since this is now handled automatically.


  This new RFA handles this removal:
Tested manually on cygwin and ubuntu/i386
without any changes in modified tests results.

 
2009-10-05  Pierre Muller  <muller@ics.u-strasbg.fr>

	* gdb.base/annota1.exp: Remove obsolete match_max increase.
	* gdb.base/annota3.exp: Idem.
	* gdb.base/maint.exp: Idem.

Index: src/gdb/testsuite/gdb.base/annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.34
diff -u -F^proc  -r1.34 annota1.exp
--- src/gdb/testsuite/gdb.base/annota1.exp	13 Jul 2009 19:20:39 -0000
1.34
+++ src/gdb/testsuite/gdb.base/annota1.exp	5 Oct 2009 06:30:43 -0000
@@ -297,12 +297,6 @@
     # test:
     # annotate-signal-handler-caller
     #
-    verbose "match_max local is: [match_max]"
-    verbose "match_max default is: [match_max -d]"
-    # This is necessary because a 2000 buffer is not enought to get
everything
-    # up to the prompt ad the test gets a timeout.
-    match_max 3000
-    verbose "match_max now is: [match_max]"
     send_gdb "backtrace\n"
     gdb_expect {
 	-re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1
$hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler
called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2
$hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" {
Index: src/gdb/testsuite/gdb.base/annota3.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v
retrieving revision 1.19
diff -u -F^proc  -r1.19 annota3.exp
--- src/gdb/testsuite/gdb.base/annota3.exp	3 Jan 2009 05:58:03 -0000
1.19
+++ src/gdb/testsuite/gdb.base/annota3.exp	5 Oct 2009 06:30:43 -0000
@@ -258,12 +258,6 @@
     #
     # test:
     #
-    verbose "match_max local is: [match_max]"
-    verbose "match_max default is: [match_max -d]"
-    # This is necessary because a 2000 buffer is not enought to get
everything
-    # up to the prompt ad the test gets a timeout.
-    match_max 3000
-    verbose "match_max now is: [match_max]"
     send_gdb "backtrace\n"
     gdb_expect_list "backtrace @ signal handler" "$gdb_prompt$" {
 	"#0 +handle_USR1 \[^\r\n\]+\r\n"
Index: src/gdb/testsuite/gdb.base/maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.37
diff -u -F^proc  -r1.37 maint.exp
--- src/gdb/testsuite/gdb.base/maint.exp	3 Jan 2009 05:58:03 -0000
1.37
+++ src/gdb/testsuite/gdb.base/maint.exp	5 Oct 2009 06:30:44 -0000
@@ -96,8 +96,6 @@
 send_gdb "set height 0\n"
 gdb_expect -re "$gdb_prompt $"
 
-# use a larger expect input buffer for long help outputs.
-match_max 6000
 
 #
 # this command does not produce any output


  reply	other threads:[~2009-10-06 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 13:58 [RFA] Testsuite: Change match_max for current also Pierre Muller
2009-10-02 23:20 ` Joel Brobecker
2009-10-06 14:46   ` Pierre Muller [this message]
2009-10-06 14:57     ` [RFA] Testsuite: Remove obsolete match_max uses Joel Brobecker
2009-10-06 15:14       ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001ca4693$7a8e1870$6faa4950$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox